Add download demo #444
Add download demo #444
Conversation
src/ui/greeting/Greeting.scss
Outdated
| margin-top: $spacer / 2; | ||
|
|
||
| * { | ||
| display: inline-block; |
There was a problem hiding this comment.
If you used a <span> instead of a <p> I don't think you need this block. You could simply move the font-size to &__DownloadDemo.
src/ui/greeting/Greeting.scss
Outdated
| &__Link { | ||
| color: $brand-primary; | ||
| cursor: pointer; | ||
| text-decoration: underline; |
There was a problem hiding this comment.
Perhaps we should move this to a more global place like styles/index.scss?
There was a problem hiding this comment.
@kraenhansen I agree with this, maybe should we create a new card for unifying all the links styles?
| @@ -20,4 +20,10 @@ body, | |||
| height: 100%; | |||
| } | |||
|
|
|||
| .Link { | |||
There was a problem hiding this comment.
Was thinking more just an a selector. Do you see an issue in that?
There was a problem hiding this comment.
@kraenhansen I prefer classes over tag selectors maybe we want to apply this styles to a button. Also, we will affect all the a in the app, are you sure about that?
There was a problem hiding this comment.
I guess your right - a Link class is probably best.
closes #315