CSV importer improved #820

kraenhansen · 2018-06-07T15:14:03Z

This improves CSV importing in a couple of ways:

Users can now import CSV into a server when selecting "Create Realm from > CSV" from the "Server Administration" window. And when importing locally the user will be asked for a destination file (which fixes Users wants to choose the location when importing from CSV - locally or on the server #685 and CSV file handling improvements #536).
Showing an error when CSV importing fails (which fixes (sometimes) After CSV import window goes blank #534).

kraenhansen self-assigned this Jun 7, 2018

kraenhansen force-pushed the kh/csv-importing-improved branch 2 times, most recently from 9ec1efb to 9c213eb Compare June 11, 2018 11:04

Kræn Hansen added 15 commits June 11, 2018 13:34

Upgraded TypeScript and fixed errors and some unused variables

5d33143

Creating a promise-handle utility

d489819

Renamed the menuUtil to menu

a54da84

Sync errors while creating a Realm now rejects the promise

781c2e5

Exporting all services in an index.ts

3039807

Hoisted the CreateRealmDialog to ServerAdministration

bda98f5

Removed cleanup from the promise-handle util

e2c8fc9

Missed three occurances of menu

8af987f

Cleaned up some types

edd9deb

Cleaned up types

f018999

Refactored onImportIntoExistingRealm into two methods

5e396ca

Restructuring the data importer

2dca349

Improved CSV importing

8a255ad

Showing an error when CSV importing fails

95a8071

Fixed "Create new Realm" cancellation

4b10b8e

kraenhansen force-pushed the kh/csv-importing-improved branch from f3d54e8 to 4b10b8e Compare June 11, 2018 11:35

kraenhansen merged commit 6f65233 into master Jun 11, 2018

kraenhansen deleted the kh/csv-importing-improved branch June 11, 2018 12:11

kraenhansen mentioned this pull request Jul 18, 2018

CSV file handling improvements #536

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024

Provide feedback