Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show absolute realm sizes in Studio #966

Merged
merged 6 commits into from Nov 6, 2018
Merged

Show absolute realm sizes in Studio #966

merged 6 commits into from Nov 6, 2018

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Oct 19, 2018

@realm-probot
Copy link

realm-probot bot commented Oct 19, 2018

Hey @nirinchev - looks like you forgot to add a T:* label - could you please add one?

@kraenhansen
Copy link
Member

@nirinchev would you care to include a screenshot in the description of the issue?

@kraenhansen
Copy link
Member

Did you consider #881 and what parts of this PR address which part of the issue? Or does it address a completely different issue? Which?

@nirinchev
Copy link
Member Author

It addresses a different issue, which is exposing the absolute Realm file size as well as a button to force size recalculation. The motivation is that we've discovered that state size computations are quite expensive, so we'll reduce the frequency to once a day and we'll only compute Realms that are currently open at the time of computation. Exposing the file size is quite cheap though, so we'll do that and allow people to manually trigger a recomputation if that's what they want.

@nirinchev nirinchev merged commit d74aedc into master Nov 6, 2018
@nirinchev nirinchev deleted the ni/realm-sizes branch November 6, 2018 09:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants