Fix async open interaction with read-only Realms #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - async open no longer opens a synced Realm conventionally at the beginning, causing data to be written to the server
jpsim
reviewed
Apr 27, 2017
Realm/RLMRealm.mm
Outdated
| return; | ||
| } | ||
| } | ||
| if (error) { |
There was a problem hiding this comment.
this check just needs to happen in the hasSyncConfig case.
jpsim
approved these changes
Apr 27, 2017
This was referenced May 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This change is verified through a unit test in an upcoming PR. (It is not included in this PR because it contains a large number of upcoming dependencies that would be impractical to port into this PR.)