When ignoredProperties is overridden on Swift, the schema ends up invalid #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2014
|
Thanks for the fix. If you have a test for this it would be great to include it as well. Otherwise I can add one after merging. |
alazier
added a commit
that referenced
this pull request
Jul 30, 2014
When ignoredProperties is overridden on Swift, the schema ends up invalid
|
I ended up writing a test for this. Feel free to contribute yours as well if you have them. |
|
About to create a new pull request with my tests for this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When overridden ignoredProperties on an RLMObject subclass (Swift), the entire schema gets invalid (it ends up with 0 properties). The reason why this is happening is, to say at least, tricky:
I'm unclear if this is a Swift bug or just an intended language "feature". But when the conditional includes an unwrapping and a method call, only the unwrapping gets evaluated. Meaning that when you do:
If ignoredPropertiesForClass is not nil, it doesn't matter what the containsObject method returns, that conditional is always going to be true. Note that I only tested this on Xcode Beta4.