Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCOCOA-2393 Add support for Xcode 16 #8618

Merged
merged 17 commits into from
Jun 18, 2024
Merged

RCOCOA-2393 Add support for Xcode 16 #8618

merged 17 commits into from
Jun 18, 2024

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Jun 11, 2024

Addresses some of #8628.

@tgoyne
Copy link
Member Author

tgoyne commented Jun 13, 2024

Needs a proper core release before this can be merged but I think the initial set of code changes are done and can be reviewed.

@bdkjones
Copy link

Is there a rough ETA on this release? Xcode 16 has many things I'd like to try, but I can't use it until Realm is buildable there.

@nirinchev
Copy link
Member

You can build the framework from source and work against that until we've done an official release.

Copy link
Collaborator

@dianaafanador3 dianaafanador3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, Just some minor comments

CHANGELOG.md Outdated Show resolved Hide resolved
@@ -1356,6 +1356,35 @@ extension Realm {
return Unchecked(ret)
}

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this be for swift less than 6, I'm a little bit confused because of the commit message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moving the old version of the function into the #if compiler(<6) block.

dependencies.list Outdated Show resolved Hide resolved
@tgoyne tgoyne changed the title Add support for Xcode 16 RCOCOA-2393 Add support for Xcode 16 Jun 18, 2024
@tgoyne tgoyne merged commit b30dcd4 into master Jun 18, 2024
129 of 133 checks passed
@tgoyne tgoyne deleted the tg/xcode-16 branch June 18, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants