Fix error data too long for column 'title' (#961)

realodix · Apr 25, 2024 · 5f2e2cf · 5f2e2cf
1 parent 5a53adb
commit 5f2e2cf
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/app/Models/Url.php b/app/Models/Url.php
@@ -31,6 +31,8 @@ class Url extends Model
 
     const GUEST_NAME = 'Guest';
 
+    const TITLE_LENGTH = 255;
+
     /**
      * The attributes that are mass assignable.
      *
@@ -114,6 +116,20 @@ protected function destination(): Attribute
         );
     }
 
+    protected function title(): Attribute
+    {
+        return Attribute::make(
+            set: function ($value) {
+                if (mb_strlen($value) > self::TITLE_LENGTH) {
+                    // $limit minus 3 because Str::limit() adds 3 extra characters.
+                    return str($value)->limit(self::TITLE_LENGTH - 3, '...');
+                }
+
+                return $value;
+            },
+        );
+    }
+
     protected function clicks(): Attribute
     {
         return Attribute::make(

diff --git a/tests/Unit/Models/UrlTest.php b/tests/Unit/Models/UrlTest.php
@@ -120,6 +120,21 @@ public function getShortUrlAttribute(): void
         $this->assertSame($expected, $actual);
     }
 
+    #[Group('u-model')]
+    public function testSetTitleLength(): void
+    {
+        $lengthLimit = Url::TITLE_LENGTH;
+
+        $url = Url::factory()->create(['title' => str_repeat('a', $lengthLimit)]);
+        $this->assertEquals($lengthLimit, strlen($url->title));
+
+        $url = Url::factory()->create(['title' => str_repeat('a', $lengthLimit - 10)]);
+        $this->assertLessThan($lengthLimit, strlen($url->title));
+
+        $url = Url::factory()->create(['title' => str_repeat('a', $lengthLimit + 10)]);
+        $this->assertEquals($lengthLimit, strlen($url->title));
+    }
+
     #[Test]
     #[Group('u-model')]
     public function setMetaTitleAttributeWhenWebTitleSetToFalse(): void