Major Code Review: Happy New Year 2023

.env.example

@@ -4,7 +4,6 @@ APP_KEY=
 APP_DEBUG=true
 APP_URL=http://localhost
 
-UH_ANONYMIZE_IP_ADDR=true
 UH_PUBLIC_SITE=true
 UH_REGISTRATION=true
 UH_HASH_LENGTH=6

.env.testing

@@ -4,7 +4,6 @@ APP_KEY=base64:SsuVzwH9xQnlEqSgTdTbBKyJ0rYrgt5Wr71vv02jDV8=
 APP_DEBUG=true
 APP_URL=http://localhost
 
-UH_ANONYMIZE_IP_ADDR=true
 UH_PUBLIC_SITE=true
 UH_REGISTRATION=true
 UH_HASH_LENGTH=6

app/Helpers/Helper.php

@@ -5,24 +5,9 @@
 use Illuminate\Support\Str;
 use Illuminate\Support\Stringable;
 use Spatie\Url\Url as SpatieUrl;
-use Symfony\Component\HttpFoundation\IpUtils;
 
 class Helper
 {
-    /**
-     * Anonymize an IPv4 or IPv6 address.
-     *
-     * @param string|null $address
-     */
-    public static function anonymizeIp($address): string
-    {
-        if (config('urlhub.anonymize_ip_addr') === false) {
-            return $address;
-        }
-
-        return IPUtils::anonymize($address);
-    }
-
     /**
      * Display the link according to what You need.
      *

app/Http/Controllers/Dashboard/AllUrlController.php

@@ -3,6 +3,7 @@
 namespace App\Http\Controllers\Dashboard;
 
 use App\Http\Controllers\Controller;
+use App\Models\Url;
 
 class AllUrlController extends Controller
 {
@@ -27,10 +28,10 @@ public function view()
     /**
      * Delete a Short URL on user (Admin) request.
      *
-     * @param mixed $url
+     * @param Url $url \App\Models\Url
      * @return \Illuminate\Http\RedirectResponse
      */
-    public function delete($url)
+    public function delete(Url $url)
     {
         $url->delete();
 

app/Http/Controllers/Dashboard/DashboardController.php

@@ -5,15 +5,16 @@
 use App\Http\Controllers\Controller;
 use App\Models\Url;
 use App\Models\User;
-use App\Models\Visit;
+use App\Services\KeyGeneratorService;
+use App\Services\UHubLinkService;
 use Illuminate\Http\Request;
 
 class DashboardController extends Controller
 {
     public function __construct(
         public Url $url,
         public User $user,
-        public Visit $visit
+        public UHubLinkService $uHubLinkService,
     ) {
     }
 
@@ -27,39 +28,37 @@ public function view()
         return view('backend.dashboard', [
             'url'  => $this->url,
             'user' => $this->user,
-            'visit' => $this->visit,
+            'keyGeneratorService' => app(KeyGeneratorService::class),
         ]);
     }
 
     /**
      * Show shortened url details page
      *
-     * @param mixed $key
+     * @param string $urlKey A unique key for the shortened URL
      * @return \Illuminate\Contracts\View\View
      */
-    public function edit($key)
+    public function edit(string $urlKey)
     {
-        $url = Url::whereKeyword($key)->firstOrFail();
+        $url = Url::whereKeyword($urlKey)->firstOrFail();
 
         $this->authorize('updateUrl', $url);
 
-        return view('backend.edit', compact('url'));
+        return view('backend.edit', ['url' => $url]);
     }
 
     /**
      * Update the destination URL
      *
      * @param Request $request \Illuminate\Http\Request
-     * @param mixed   $url
+     * @param Url     $url     \App\Models\Url
      * @return \Illuminate\Http\RedirectResponse
      *
      * @throws \Illuminate\Auth\Access\AuthorizationException
      */
-    public function update(Request $request, $url)
+    public function update(Request $request, Url $url)
     {
-        $url->destination = $request->long_url;
-        $url->title = $request->title;
-        $url->save();
+        $this->uHubLinkService->update($request, $url);
 
         return to_route('dashboard')
             ->withFlashSuccess(__('Link changed successfully !'));
@@ -68,12 +67,12 @@ public function update(Request $request, $url)
     /**
      * Delete shortened URLs
      *
-     * @param mixed $url
+     * @param Url $url \App\Models\Url
      * @return \Illuminate\Http\RedirectResponse
      *
      * @throws \Illuminate\Auth\Access\AuthorizationException
      */
-    public function delete($url)
+    public function delete(Url $url)
     {
         $this->authorize('forceDelete', $url);
 
@@ -84,12 +83,12 @@ public function delete($url)
     }
 
     /**
-     * @param mixed $key
+     * @param string $urlKey A unique key for the shortened URL
      * @return \Illuminate\Http\RedirectResponse
      */
-    public function duplicate($key)
+    public function duplicate($urlKey)
     {
-        $this->url->duplicate($key, auth()->id());
+        $this->uHubLinkService->duplicate($urlKey);
 
         return redirect()->back()
             ->withFlashSuccess(__('The link has successfully duplicated.'));

app/Http/Controllers/Dashboard/User/ChangePasswordController.php

@@ -21,7 +21,7 @@ public function view(User $user)
     {
         $this->authorize('view', $user);
 
-        return view('backend.user.changepassword', compact('user'));
+        return view('backend.user.changepassword', ['user' => $user]);
     }
 
     /**

app/Http/Controllers/Dashboard/User/UserController.php

@@ -38,7 +38,7 @@ public function edit(User $user)
     {
         $this->authorize('view', $user);
 
-        return view('backend.user.profile', compact('user'));
+        return view('backend.user.profile', ['user' => $user]);
     }
 
     /**