Merge pull request #28 from vuLgAr/dry-config

dry config

project/server/config.py

@@ -1,40 +1,36 @@
 # project/server/config.py
 
 import os
+
 basedir = os.path.abspath(os.path.dirname(__file__))
 
 
 class BaseConfig(object):
     """Base configuration."""
-    SECRET_KEY = 'my_precious'
-    BCRYPT_LOG_ROUNDS = 13
-    WTF_CSRF_ENABLED = True
+    BCRYPT_LOG_ROUNDS = 4
     DEBUG_TB_ENABLED = False
-    DEBUG_TB_INTERCEPT_REDIRECTS = False
+    SECRET_KEY = os.getenv('SECRET_KEY', default='my_precious')
     SQLALCHEMY_TRACK_MODIFICATIONS = False
+    WTF_CSRF_ENABLED = False
 
 
 class DevelopmentConfig(BaseConfig):
     """Development configuration."""
-    BCRYPT_LOG_ROUNDS = 4
-    WTF_CSRF_ENABLED = False
+    DEBUG_TB_ENABLED = True
+    DEBUG_TB_INTERCEPT_REDIRECTS = False
     SQLALCHEMY_DATABASE_URI = 'sqlite:///{0}'.format(
         os.path.join(basedir, 'dev.db'))
-    DEBUG_TB_ENABLED = True
 
 
 class TestingConfig(BaseConfig):
     """Testing configuration."""
-    TESTING = True
-    BCRYPT_LOG_ROUNDS = 4
-    WTF_CSRF_ENABLED = False
-    SQLALCHEMY_DATABASE_URI = 'sqlite:///'
-    DEBUG_TB_ENABLED = False
     PRESERVE_CONTEXT_ON_EXCEPTION = False
+    SQLALCHEMY_DATABASE_URI = 'sqlite:///'
+    TESTING = True
 
 
 class ProductionConfig(BaseConfig):
     """Production configuration."""
-    SECRET_KEY = 'my_precious'
+    BCRYPT_LOG_ROUNDS = 13
     SQLALCHEMY_DATABASE_URI = 'postgresql://localhost/example'
-    DEBUG_TB_ENABLED = False
+    WTF_CSRF_ENABLED = True

project/tests/test__config.py

@@ -2,6 +2,7 @@
 
 
 import unittest
+import os
 
 from flask import current_app
 from flask_testing import TestCase
@@ -48,6 +49,10 @@ def test_app_is_production(self):
         self.assertTrue(app.config['WTF_CSRF_ENABLED'] is True)
         self.assertTrue(app.config['BCRYPT_LOG_ROUNDS'] == 13)
 
+    def test_secret_key_has_been_set(self):
+        self.assertTrue(app.secret_key == os.getenv(
+            'SECRET_KEY', default='my_precious'))
+
 
 if __name__ == '__main__':
     unittest.main()