Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to save the test report to a file #28

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Added an option to save the test report to a file #28

merged 1 commit into from
Feb 4, 2019

Conversation

koleror
Copy link
Collaborator

@koleror koleror commented Feb 1, 2019

No description provided.

@mjhea0
Copy link
Contributor

mjhea0 commented Feb 1, 2019

@koleror it looks like each of the Travis tests are failing with:

The command "flake8 --max-line-length=100 --max-complexity=10 --statistics --benchmark django_slowtests" exited with 1.

Can you take a look at this?

@koleror
Copy link
Collaborator Author

koleror commented Feb 1, 2019

I know but did not really want to modify the run function too much, as it's been copied/past from unittest, with only one additional line (the last one before the return), so I wanted to make the change readable :)
But I can split it if you prefer.

@mjhea0
Copy link
Contributor

mjhea0 commented Feb 1, 2019

Just update this line, changing the max-line-length and max-complexity to get it to pass for now.

flake8 --max-line-length=100 --max-complexity=10 --statistics --benchmark django_slowtests

@koleror
Copy link
Collaborator Author

koleror commented Feb 1, 2019

Ok, thanks!
I'll do it now

@koleror koleror changed the base branch from master to dev February 4, 2019 18:08
@koleror koleror merged commit 982a131 into realpython:dev Feb 4, 2019
@koleror koleror deleted the report_as_json_file branch February 4, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants