Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample code for the article on string formatting #529

Merged
merged 8 commits into from May 17, 2024

Conversation

lpozo
Copy link
Contributor

@lpozo lpozo commented Apr 25, 2024

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Copy link
Contributor

@gahjelle gahjelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @lpozo

I have two small comments that you can have a look at.


a = 5
b = 10
sum_template = "{0} plus {1} is {2}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move the templates to the top here (and in line 11), similarly to how we did in the tutorial?

Comment on lines 3 to 4
"Progress Report. Student: {name}"
"Average: {average:.2f} / 100"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can remove the quotes here.

@brendaweles brendaweles merged commit b2f1ab8 into master May 17, 2024
1 check passed
@brendaweles brendaweles deleted the python-string-formatting-update branch May 17, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants