Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade linters and switch to Ruff #530

Merged
merged 7 commits into from
May 6, 2024
Merged

Conversation

gahjelle
Copy link
Contributor

@gahjelle gahjelle commented May 3, 2024

Upgrade the GitHub Action to use Python 3.12 and Black 24. Change linter from Flake8 to Ruff.

@gahjelle gahjelle requested a review from dbader May 3, 2024 10:48
Copy link
Member

@dbader dbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gahjelle!

@dbader
Copy link
Member

dbader commented May 4, 2024

I've temporarily removed the branch protection rule @gahjelle so you can go ahead with the merge on Monday. Please send me a quick ping once that's done so I can bring back the new branch protection rule. (Or maybe you can do it as well).

@dbader
Copy link
Member

dbader commented May 4, 2024

@gahjelle Actually, scratch that. I misunderstood the branch protection rules UI and now I was able to add the new Linux312 action as required. So we should be able to merge this PR.

@gahjelle gahjelle merged commit 762eaee into master May 6, 2024
1 check passed
@gahjelle gahjelle deleted the actions-upgrade-to-312 branch May 6, 2024 11:34
@gahjelle
Copy link
Contributor Author

gahjelle commented May 6, 2024

Thanks @dbader

I've merged this one and the new 3.12 action seems to work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants