New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add materials for binary search #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, Bartosz! Approved with two minor suggestions below...
def main(): | ||
"""Script entry point.""" | ||
|
||
print("Fetching data from IMDb...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a slow connection, this might take a while. You might want to call that out in the print
statement, but if it's in the article text, then no worries.
|
||
times: List[int] = [] | ||
for i in range(repeat): | ||
print(f"[{i + 1}/{repeat}] Searching...", end="", flush=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The random search can take a while - you might want to call that out if that's the search being conducted. If you call it out in the article, then no worries...
Where to put new files:
my-awesome-article
How to merge your changes: