Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add materials for binary search #84

Merged
merged 9 commits into from Nov 14, 2019
Merged

Add materials for binary search #84

merged 9 commits into from Nov 14, 2019

Conversation

bzaczynski
Copy link
Contributor

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 馃帀

Copy link
Contributor

@JFincher42 JFincher42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, Bartosz! Approved with two minor suggestions below...

def main():
"""Script entry point."""

print("Fetching data from IMDb...")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a slow connection, this might take a while. You might want to call that out in the print statement, but if it's in the article text, then no worries.


times: List[int] = []
for i in range(repeat):
print(f"[{i + 1}/{repeat}] Searching...", end="", flush=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The random search can take a while - you might want to call that out if that's the search being conducted. If you call it out in the article, then no worries...

@bzaczynski bzaczynski merged commit 8e41a3d into master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants