Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean up #1

Merged
merged 7 commits into from
Mar 2, 2021
Merged

Code clean up #1

merged 7 commits into from
Mar 2, 2021

Commits on Feb 10, 2021

  1. Update README.md

    lpozo committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    70ae0c0 View commit details
    Browse the repository at this point in the history
  2. Remove black line

    lpozo committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    a5d424d View commit details
    Browse the repository at this point in the history
  3. Multiple refactors on main() and parse_cmd_line_arguments().

    On main():
    
    - Remove blank likes
    - Update the order of the arguments to DirectoryTree constructor
    
    On parse_cmd_line_arguments():
    
    - Remove unneeded upper case letter from strings
    - Move the version attribute up
    - Remove the unneeded type argument because str is the default type for command-line arguments
    lpozo committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6772f93 View commit details
    Browse the repository at this point in the history
  4. Multiple refactors on DirectoryTree and _TreeGenerator.

    - Add a missing import
    - Add a new module-level constant to provide a new prefix
    
    On DirectoryTree
    
    - Swap the order of the argument in the class initializer
    - Update functions calls and rename item to entry
    
    On _TreeGenerator
    
    - Rename the first argument of the initializer to be more consistent with the current API
    - Turn .dir_only into a non-public attribute
    - Use a deque instead of a list to optimize the insertions of item at the beginning of the data structure
    - Rename the dir argument to directory so we can avoid name collisions with the built-in dir() function
    - Remove the path local variable joining
    - Rename path to entry so we maintain a uniform naming
    - Move the path argument to the beginning of the argument in _add_file(). Also, it was renamed from path to file
    lpozo committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    f729e5f View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Configuration menu
    Copy the full SHA
    a9d243e View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Update README.md

    lpozo committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    5a9ce07 View commit details
    Browse the repository at this point in the history
  2. Symplify _prepare_entries()

    lpozo committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    86057e8 View commit details
    Browse the repository at this point in the history