Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert::image function modification #134

Closed
SaedyMoz opened this issue Feb 25, 2022 · 1 comment
Closed

Alert::image function modification #134

SaedyMoz opened this issue Feb 25, 2022 · 1 comment

Comments

@SaedyMoz
Copy link

  • Package Version: 5.0

Description:

Alert function with image last argument must be nullable and Documentation needs to be modified.
Alert::image() accept 6 argument and last argument is optinal. but in RealRashid\SweetAlert\Toaster class the six argument not considered as null. It produces an error if we proceed according to the documentation. This function should be modified as follows:
public function image($title, $text,$imageUrl, $imageWidth, $imageHeight, $imageAlt= null) { ... }

@realrashid
Copy link
Owner

realrashid commented Feb 25, 2022 via email

realrashid added a commit that referenced this issue May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants