First step to remove globals in dev src #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
michalbcz
approved these changes
Nov 1, 2016
| @@ -1,11 +1,14 @@ | |||
| // generated on 2016-09-28 using generator-chrome-extension 0.6.1 | |||
| import gulp from 'gulp'; | |||
There was a problem hiding this comment.
why did you replace ES6's import with require in this case?
There was a problem hiding this comment.
I have to admit it was unintentional. Since I never used gulp before, I did run it in a wrong way a imports didn't worked for me (to be precise, I've tried to rename gulpfile.babel.js to gulpfile.jswhich caused the behavior with having not import working...
Finally before committing I've renamed the file back to original name and forgot to revert the requires ;( I' will create a PR to bring it back since it's the goal to use ES modules...
But in general it's not good that software behaves differently just based on some string in filename like .babel because it isn't obvious for the first look...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.