Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Daily] Hidden-Line Pick Bugs - "Auto-Transparent Pick" disables when Hidden-Line pick is highlighted, and Hidden-Line pick does not work with "Experimental" Render Cache #312

Closed
scottmudge opened this issue Apr 11, 2022 · 5 comments

Comments

@scottmudge
Copy link

scottmudge commented Apr 11, 2022

Reporting from the tip of LinkDaily as of 04/11/2022.

Two issues with Hidden-Line Pick:

  1. The Auto-Transparent Pick feature successfully allows the user to select hidden lines when [Shift] is held, however the transparent preview disables itself when a hidden-line pick is being previewed. The selected parent object (if occluded) does get placed on-top after selection is made.

Example:

FreeCAD_xRt3ivrKXB.mp4

(^ You may need to download and open in VLC)

  1. You are probably aware, but the Hidden-Line Pick feature does not work with the Experimental render cache.
@scottmudge
Copy link
Author

Nice! Looks beautiful.

Thanks!

@realthunder
Copy link
Owner

The above commit fixed a problem I found when investigating your report. This may or may not be the problem you have.

Please note that the Auto Transparent Pick is supposed to work in all render cache modes. But there are different behaviors. The one you showed in screen cast is the expected behavior of Auto Transparent Pick in non-experimental caching mode. It will make the pre-selected object transparent but will not make the object show on top, and hence will not enable auto hidden line picking. That's why you still need the Shift key to enable hidden line picking.

With experimental caching, pre-selected object will be shown on top, and hidden line picking is enabled without needing to hold the Shift key. The above commit fixed a bug in this mode.

@scottmudge
Copy link
Author

It seems to have fixed my problem, and the experimental render cache works now too. Perhaps I didn't describe the original problem well to go along with the video. In any case, it's fixed!

Unrelated, but what's the plan/trajectory for merging the primary FreeCAD repo into LinkDaily? There's a few features now I'd love to use (e.g., the offset feature in the sketcher), but I don't want to abandon the benefits of your branch either.

@realthunder
Copy link
Owner

There is huge code refactoring in upstream recently, Sketcher WB being one of them. I'll do a merge once upstream 0.20 is released, probably in a month or so I think.

@scottmudge
Copy link
Author

Yeah it's impressive work. Sounds awesome, I look forward to it! Thanks!

realthunder added a commit that referenced this issue Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants