Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate pick radius for points vs lines #605

Closed
jpedrick opened this issue May 9, 2021 · 19 comments
Closed

Separate pick radius for points vs lines #605

jpedrick opened this issue May 9, 2021 · 19 comments

Comments

@jpedrick
Copy link

jpedrick commented May 9, 2021

On the latest daily release 2021-05-04, picking points has become very difficult in sketch mode. I have to zoom in until the display accuracy offsets the points from the line. Using gg doesn't work if you need to pick multiple points, as the previous selection is un-selected. I think the issue could be fixed, or at least worked around, if lines had a different pick radius vs vertexes.

@realthunder
Copy link
Owner

realthunder commented May 9, 2021

I can't seem to reproduce the problem. Also, can you please post a screencast showing the problem?

Also, please send me your link.user.cfg file. On Windows it is in c:\Users\<your_user_name>\AppData\Roaming\FreeCAD. On MacOS it is in ~\Library\Preferences\FreeCAD. And On Linux, it is in ~\.FreeCAD.

@bambukouk
Copy link

bambukouk commented May 9, 2021

Just had exactly the same problem, I am afraid.
Closed model in Link, opened it in 0.20 and picking points in sketch edit worked perfectly OK.

BTW do you mean link.user.cfg or linker.user.cfg
I have attached the first one:
link.user.cfg.txt

PS
next sketch I did was fine. so it is very erratic behaviour ...
Will report if it repeats again

OS: Windows 10 Version 1909 Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 2021.504.24301 +3597 (Git) Build type: Release Branch: LinkDaily Hash: 540995a6e8d5db01dfe2597439ec3131ca69b030 Python version: 3.8.6+ Qt version: 5.15.2 Coin version: 4.0.1 OCC version: 7.5.0 Locale: English/United Kingdom (en_GB)

@krkpatrck
Copy link

krkpatrck commented May 9, 2021

I can not select a vertex in sketcher. i had a sketch i padded then went back to make and edit. i deleted a line and tried to make a new one. however, i was never able to attach the line vertex to the previous vertex. i could highlight the line but never the vertex.
im using FreeCAD-asm3-Daily-Conda-Py3-Qt5-20210504-glibc2.12-x86_64.AppImage

@realthunder
Copy link
Owner

Can any of you provide a screencast recording for the problem, starting from creating the sketch and then show the highlighting problem? I still can't reproduce the problem even with @bambukouk link.user.cfg file.

@krkpatrck
Copy link

ill be back on tomorrow to see if i cant get a screenshot of the issue.

@jpedrick
Copy link
Author

I'm not that savvy with screencasting, but I played around with a model until I started having the vertex selection problem. What it seemed like I had to do was close the sketch and return to it.

Other things I did first:

  • spin the object around and sketch on the back
  • offset the sketch by -5mm inside the object

@realthunder maybe if you open this and try editing Sketch002 you'll be able to replicate the issue.

vertex_selection_problem.zip

@bambukouk
Copy link

bambukouk commented May 10, 2021

Please find attached screen grab video of me trying to edit existing sketch.
You will see:

  • me trying to pick up the points (by pointing to them with the cursor) - resulting in lines being selected
  • picking lines is no problem
  • you can select point by selecting a window containg it

one thing that is common (probably...?) to sketches having problems, is that they come imported from models created in earlier (0.19 or 0.20) versions of FreeCAD (recomputed succesfuly and working fine in Link)
Newly created sketches don't seem to have the problem?

later edit - above comment about which sketches have problem is NOT correct - there doesn't seem to be logic as to which ones are affected - sorry.

2021-05-10 08-38-45.zip

@bambukouk
Copy link

@jpedrick

I'm not that savvy with screencasting,

I have played with your file and the problem is exactly the same as I am experiencing.
I have attached screen grab (hopefully self explanatory)
2021-05-10 09-59-10.zip

@herrgerd
Copy link

herrgerd commented May 10, 2021

@ #605 (comment)

I can confirm the behaviour!
It occurs only when you have an sketch with a negative offset (-30mm in this case, exact value doesn't matter). Then you can't select vertex points and it doesn't connect points.

negOffsetVertexes
Open gif in new Tab for full resolution.

@realthunder I did another test with a blank file and just a sketch on a plane. Does work with plus or zero offset. Doesn't work with negative. At least for me:
negOffsetVertexes_2

OS: Windows 10 Version 2009
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 2021.504.24301 +3597 (Git)
Build type: Release
Branch: LinkDaily
Hash: 540995a6e8d5db01dfe2597439ec3131ca69b030
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.0
Locale: German/Germany (de_DE)

@bambukouk
Copy link

bambukouk commented May 10, 2021

@herrgerd

It occurs only when you have an sketch with a negative offset (-30mm in this case, exact value doesn't matter). Then you can't select vertex points and it doesn't connect points.

My sketch (in XZ plane) in my previous post was placed at Y=+73mm and it still had the same problem..., so it is possibly not the negative offset?

@krkpatrck
Copy link

ok so..... while im in sketcher. If i spin my sketch not a full 180 as to edit it from the back but more like a 45 I can then grab vertexes.

realthunder added a commit to realthunder/FreeCAD that referenced this issue May 11, 2021
@realthunder
Copy link
Owner

Finally, this problem should be fixed now. Thanks all for reporting and the follow up. As a bonus, I have also enhanced datum label in sketcher so that it will always has a readable orientation no matter how you rotate the view, or even editing through a link that mirrors the sketch.

@bambukouk
Copy link

That's excellent news (about editing thorugh a mirrored link) - lot of my stuff is mirrored, so really appreciate it.

@herrgerd
Copy link

Finally, this problem should be fixed now. Thanks all for reporting and the follow up. As a bonus, I have also enhanced datum label in sketcher so that it will always has a readable orientation no matter how you rotate the view, or even editing through a link that mirrors the sketch.

Thank you @realthunder

BTW: I am still very often having problems selecting certain constraints (e.g. to delete them):
selectingConstraints

Most of the time its the vertical or horizontal constraint. In general selecting one of more than two near to each other does not work.

Using the "g g" shortcut doesn't show them either.

KabelkanalUntertisch.zip

@mwlandolsi
Copy link

Hello everybody
While trying to reproduce the bug I remarked that when I put a point on the vertexes, all points are selected and points are putted on every vertex (see video at 10s) . This happens only in the first selection just after selecting the edjes. If I undo (^z) and try to repeat to put a point on sketch vertexes, only one point is chosen and that what should really happen.
simplescreenrecorder-2021-05-11_20.31.49.mkv.zip

realthunder added a commit to realthunder/FreeCAD that referenced this issue May 12, 2021
@jpedrick
Copy link
Author

jpedrick commented May 12, 2021

@realthunder thanks for the quick fix!

Maybe this is worthy of a preview release? I don't mind building FreeCAD myself, but I've gotten addicted to AppImage releases.

@herrgerd
Copy link

herrgerd commented May 13, 2021

Yay, the picking problem with negative offsets seems to be gone now!

@realthunder
Copy link
Owner

@mwlandolsi, the turning green thing is not really a bug. It is simply showing your sketch as fully constrained, because all your points are fixed by the coincidence constraint to the external vertices.

@oficinerobotica
Copy link
Collaborator

@jpedrick Closing this issue as it really seems to be resolved although we don't have different pick radius for point and line. If you think otherwise it can always be reopened. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants