Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation support #1332

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hasecilu
Copy link

This started trying to figure out why translations were not showing on FreeCAD and end up with a lot of changes, mainly grouping strings by context and adding Spanish translation.

I made translatable the WB's name and tooltip for some folks that want to translate to their language. Do you prefer another tooltip?

    MenuText = translate("asm3", "Assembly 3")
    ToolTip = translate("asm3", "Assembly 3 workbench")

Without this line of code the translations dont't appear (at least) on FreeCAD
0.21.2 and 0.22.dev. It wasn't mentioned on the Wiki but I just updated
«Translating an external workbench» article.
- Translation was in translator comment tag, moved to translation tag.
- Update location path, this enables to visualize code in Qt Linguist
- May need a cleanup
Having all strings on "asm3" group makes a little harder to found where are
used the strings and choose a good translation.

This changes separate the commands per groups in the toolbar.
- asm3
- asm3Logger
- asm3Constraints
- asm3Constraints2
- asm3ContraintsSketch
- asm3Measurements
- asm3Navigation

Some typos fixed
The base `asm3.ts` file is updated to have the new context groups
and to have the correct location path, this is useful to show code
in Qt Linguist to help on translation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant