Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(appimage): upgrade to Python 3.8.18 #704

Merged
merged 1 commit into from Feb 16, 2024

Conversation

tiborsimko
Copy link
Member

@tiborsimko tiborsimko commented Feb 12, 2024

Fixes AppImage building procedure by upgrading to Python 3.8.18.

tiborsimko added a commit to tiborsimko/reana-client that referenced this pull request Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe0b00a) 58.62% compared to head (783c17a) 58.62%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   58.62%   58.62%           
=======================================
  Files          24       24           
  Lines        2393     2393           
=======================================
  Hits         1403     1403           
  Misses        990      990           

@tiborsimko tiborsimko changed the title build(appimage): upgrade to Python 3.8.12 build(appimage): upgrade to Python 3.8.18 Feb 12, 2024
tiborsimko added a commit to tiborsimko/reana-client that referenced this pull request Feb 12, 2024
Fixes AppImage building procedure by upgrading to Python 3.8.18.
@tiborsimko tiborsimko added this to In review in 0.9.3 Feb 13, 2024
Copy link
Member

@giuseppe-steduto giuseppe-steduto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
A small note: I had to run the script as superuser in order to have the permission to complete the AppImage build process successfully. Is this intended behavior?

@tiborsimko
Copy link
Member Author

had to run the script as superuser in order to have the permission to complete the AppImage build process successfully. Is this intended behavior?

Hmm, I'm running it as a regular use. Perhaps we can see IRL about the troubles you've met?

@tiborsimko
Copy link
Member Author

Hmm, I'm running it as a regular use. Perhaps we can see IRL about the troubles you've met?

I managed to reproduce a runtime error: it happens when I launch this script whilst being in the reana virtual environment. However, when you deactivate first, and use the vanilla operating system Python, then the script runs fine. Perhaps you tried it out whilst being in the reana venv?

Fixes AppImage building procedure by upgrading to Python 3.8.18.
Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well after the latest changes (outside the reana venv)

@tiborsimko tiborsimko merged commit 783c17a into reanahub:master Feb 16, 2024
26 checks passed
0.9.3 automation moved this from In review to Done Feb 16, 2024
@tiborsimko tiborsimko deleted the fix-appimage-creation branch February 16, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.9.3
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants