fix(utils): update failed workflows duration using finished time #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Jan 18, 2024
…nahub#387) Fix the way in which the duration of failed workflows is calculated, to use the time at which the run was finished rather than the current time. Closes reanahub#386.
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Jan 18, 2024
giuseppe-steduto
force-pushed
the
fix-failed-workflow-duration
branch
from
fc87a2f
to
4300008
Compare
mdonadoni
reviewed
Jan 24, 2024
reana-ui/src/util.test.js
Outdated
| }, | ||
| }; | ||
|
|
||
| advanceTo(new Date(2024, 0, 18, 8, 50, 0)); |
There was a problem hiding this comment.
minor: maybe we can use setSystemTime of jest, to avoid a new dependency? Unless the new library has more features that we need https://jestjs.io/docs/jest-object#jestsetsystemtimenow-number--date
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Jan 24, 2024
…nahub#387) Fix the way in which the duration of failed workflows is calculated, to use the time at which the run was finished rather than the current time. Closes reanahub#386.
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Jan 24, 2024
giuseppe-steduto
force-pushed
the
fix-failed-workflow-duration
branch
from
4300008
to
3cbd481
Compare
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Jan 24, 2024
…nahub#387) Fix the way in which the duration of failed workflows is calculated, to use the time at which the run was finished rather than the current time. Closes reanahub#386
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Jan 24, 2024
giuseppe-steduto
force-pushed
the
fix-failed-workflow-duration
branch
from
3cbd481
to
4b0ff59
Compare
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Jan 25, 2024
…anahub#387) Fix the way in which the duration of failed workflows is calculated, to use the time at which the run was finished rather than the current time. Closes reanahub#386
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Jan 25, 2024
giuseppe-steduto
force-pushed
the
fix-failed-workflow-duration
branch
from
4b0ff59
to
032ada2
Compare
mdonadoni
approved these changes
Feb 12, 2024
…anahub#387) Fix the way in which the duration of failed workflows is calculated, to use the time at which the run was finished rather than the current time. Closes reanahub#386
giuseppe-steduto
added a commit
to giuseppe-steduto/reana-ui
that referenced
this pull request
Feb 12, 2024
giuseppe-steduto
force-pushed
the
fix-failed-workflow-duration
branch
from
032ada2
to
e5a4af3
Compare
mdonadoni
reviewed
Feb 13, 2024
run-tests.sh
Outdated
| @@ -29,7 +29,7 @@ check_commitlint () { | |||
| } | |||
|
|
|||
| check_shellcheck () { | |||
| find . -name "*.sh" -exec shellcheck {} \+ | |||
| find . -name "*.sh" ! -path "./reana-ui/node_modules/*" -exec shellcheck {} \; | |||
There was a problem hiding this comment.
Suggested change
| find . -name "*.sh" ! -path "./reana-ui/node_modules/*" -exec shellcheck {} \; | |
| find . -name "*.sh" ! -path "./reana-ui/node_modules/*" -exec shellcheck {} \+ |
giuseppe-steduto
force-pushed
the
fix-failed-workflow-duration
branch
from
e5a4af3
to
8913e4d
Compare
mdonadoni
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(utils): update failed workflows duration using finished time
Fix the way in which the duration of failed workflows is calculated, to
use the time at which the run was finished rather than the current time.
Closes ui: workflow duration keeps changing for failed workflows #386
ci(shellcheck): exclude node_modules from the analyzed paths