ci(commitlint): addition of commit message linter #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 28.47% 28.47%
=======================================
Files 5 5
Lines 144 144
=======================================
Hits 41 41
Misses 103 103 |
tiborsimko
added a commit
to tiborsimko/reana-workflow-engine-serial
that referenced
this pull request
Jan 10, 2024
Adds commitlint to check the commit message style against agreed conventional commits configuration. Changes script argument values to always use linter names (e.g. shellcheck). Changes argument handling to allow only one checking action that can now accept further optional arguments.
tiborsimko
force-pushed
the
commitlint
branch
from
bed2287
to
2d7738a
Compare
tiborsimko
added a commit
to tiborsimko/reana-workflow-engine-serial
that referenced
this pull request
Jan 10, 2024
mdonadoni
approved these changes
Jan 11, 2024
MANIFEST.in
Outdated
| include *.rst | ||
| include *.sh | ||
| include *.txt | ||
| include *.yaml | ||
| include *.yaml |
There was a problem hiding this comment.
include *.yaml it's duplicated in MANIFEST.in
Adds commitlint to check the commit message style against agreed conventional commits configuration. Changes script argument values to always use linter names (e.g. shellcheck). Changes argument handling to allow only one checking action that can now accept further optional arguments.
tiborsimko
added a commit
to tiborsimko/reana-workflow-engine-serial
that referenced
this pull request
Jan 11, 2024
tiborsimko
force-pushed
the
commitlint
branch
from
427d417
to
c7b0aff
Compare
tiborsimko
force-pushed
the
commitlint
branch
from
c7b0aff
to
d40a675
Compare
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds commitlint to check the commit message style against agreed conventional commits configuration.
Changes script argument values to always use linter names (e.g. shellcheck).
Changes argument handling to allow only one checking action that can now accept further optional arguments.