fix(executor): override default resources to remove mem/disk (#91)

[mdonadoni]

Closes #90

[tiborsimko]

Works nicely 👍

$ rcg logs -w root6-roofit-snakemake-kubernetes.1 | grep resources:
    resources: mem_mb=1000, mem_mib=954, disk_mb=1000, disk_mib=954, tmpdir=<TBD>, kubernetes_memory_limit=256Mi
    resources: mem_mb=1000, mem_mib=954, disk_mb=1000, disk_mib=954, tmpdir=<TBD>, kubernetes_memory_limit=256Mi
    resources: mem_mb=1000, mem_mib=954, disk_mb=1000, disk_mib=954, tmpdir=/tmp

$ rcg logs -w root6-roofit-snakemake-kubernetes.2 | grep resources:
    resources: tmpdir=<TBD>, kubernetes_memory_limit=256Mi
    resources: tmpdir=<TBD>, kubernetes_memory_limit=256Mi
    resources: tmpdir=/tmp

Left a minor note on the explaining comment.

Since this is a well-isolated fix, perhaps it should go to maint-0.9 as well...

[tiborsimko]

A suggestion for the comment:

        # Since Snakemake v7.3.0, the workflow logs include Snakemake-percieved native
        # resource information on memory and storage (`mem_mb`, `disk_mb`) for each
        # Snakemake rule run on cloud. However, REANA overrides these when running 
        # user jobs, so we should hide these in order not to present any misleading 
        # information to users. For this reason, the default resources are overridden 
        # here with the only the "bare" ones (`tmpdir`).

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 3.78%. Comparing base (f63e5cb) to head (572a83f).

Additional details and impacted files

@@             Coverage Diff              @@
##           maint-0.9     #91      +/-   ##
============================================
- Coverage       3.82%   3.78%   -0.05%     
============================================
  Files              6       6              
  Lines            183     185       +2     
============================================
  Hits               7       7              
- Misses           176     178       +2     

Files	Coverage Δ
reana_workflow_engine_snakemake/executor.py	0.00% <0.00%> (ø)