Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: release build is not aware of BUILD_ARGUMENTS #342

Closed
tiborsimko opened this issue Jun 12, 2020 · 1 comment
Closed

make: release build is not aware of BUILD_ARGUMENTS #342

tiborsimko opened this issue Jun 12, 2020 · 1 comment
Projects

Comments

@tiborsimko
Copy link
Member

Setting BUILD_ARGUMENTS works for developer-oriented builds, such as:

$ DEMO=r-d-r-roofit EXCLUDE_COMPONENTS=r-ui,r-m-broker BUILD_ARGUMENTS="COMPUTE_BACKENDS=htcondorcern,slurmcern,kubernetes" make ci

However it does not work for release builds, so images such as reanahub/reana-job-controller-htcondorcern-slurmcern:0.6.0-31-g35c4fc8 are not having Condor installed.

Three solutions:

  • manually, as a quick fix, one can do reana-dev docker-build -c r-j-controller -b COMPUTE_BACKENDS=htcondorcern,slurmcern,kubernetes and push this image over the created one;

  • one permanent solution would be to improve Makefile to make it aware of BUILD_ARGUMENTS to make the fix permanent;

  • the other permanent solution would be to address this as part of make: move to shell scripts #304.

@tiborsimko tiborsimko added this to Ready for work in v0.7.0 Jun 12, 2020
@diegodelemos diegodelemos moved this from Ready for work to In work in v0.7.0 Jul 31, 2020
@diegodelemos diegodelemos self-assigned this Jul 31, 2020
@diegodelemos diegodelemos moved this from In work to Ready for work in v0.7.0 Aug 5, 2020
@diegodelemos diegodelemos removed their assignment Aug 5, 2020
@tiborsimko
Copy link
Member Author

The build arguments have been moved to shell scripts. What remains to be done is the naming of the docker image. This is related to issues #370 and #363. I'll add a comment there and close the issue here.

v0.7.0 automation moved this from Ready for work to Done Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.7.0
  
Done
Development

No branches or pull requests

2 participants