Fix errors on Windows #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency is unused, but its presence causes Windows compilation to fail.
Adding an ellipsis and rephrasing emphasised that some messages are info, not error messages. Without this some messages seem like errors even though they are not.
|
Great! Thanks! |
Closed
lemmih
added a commit
that referenced
this pull request
Jun 24, 2020
Fix errors on Windows Former-commit-id: b2cf3f72f0403ffec17b973e7b4776721dcafd90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some suggestions from #1, in particular:
unixdependency to get compilation to workopen-browserpackage instead of using custom code, which expands the range of platforms supported (including Windows)An additional third change has also been implemented, namely rephrasing some info messages; previously some of these messages looked like they were errors, causing the impression that
reanimatewasn't working.