Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Delete/Remove Take function #1097

Closed
X-Raym opened this issue Jan 31, 2019 · 3 comments · Fixed by #1610
Closed

API: Delete/Remove Take function #1097

X-Raym opened this issue Jan 31, 2019 · 3 comments · Fixed by #1610

Comments

@X-Raym
Copy link
Contributor

X-Raym commented Jan 31, 2019

Hi,

There is no delete takes from items API function, it require handling items chunk.

There is some BR actions which does that like for deleting item under mouse like this :

SNM_TakeParserPatcher takePatcher(mouseInfo.GetItem());
takePatcher.RemoveTake(mouseInfo.GetTakeId());

I think this could be exposed to ReaScript.

It could be DeleteTake( *take) or simply DeleteTakeFromItem( item, id )

What do you think ?

Cheers !

@nofishonfriday
Copy link
Collaborator

Maybe check how Breeder deletes takes in his script?
https://forum.cockos.com/showthread.php?t=216665

Haven't looked at the code myself, would that be a viable alternative?

@StephanRoemer
Copy link

It's funny, because Breeder himself complained about a missing delete take function ;)

@X-Raym
Copy link
Contributor Author

X-Raym commented Feb 4, 2019

@StephanRoemer This is why I posted the request 😄

@nofishonfriday most advanced lua solution only is mpl's take parser. But it's Lua only. I would choose this solution if I needed it right now personally, but it is more like a "would be good to have in the future cause we never know" type of request. It's surprising that this isn't already a native function.

@X-Raym X-Raym changed the title API: delete take API: Delete/Remove Take function Feb 13, 2022
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 14, 2022
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants