Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions with "Wait **** seconds before next action" don't work with cycle action. #1656

Closed
ovnis82 opened this issue Jul 15, 2022 · 1 comment · Fixed by #1686
Closed

Actions with "Wait **** seconds before next action" don't work with cycle action. #1656

ovnis82 opened this issue Jul 15, 2022 · 1 comment · Fixed by #1686
Assignees
@cfillion

Comments

@ovnis82
Copy link

ovnis82 commented Jul 15, 2022

Tested with Reaper@stock.
@cfillion
Copy link
Collaborator

cfillion commented Oct 12, 2022 •
edited

Confirmed. According to a comment in the source code (c36a42c) it seems this used to work around year 2014. But now these actions are hard-coded in REAPER's custom action handler. They do nothing when in a SWS cycle action.

I suppose we could hard-code our own behavior for them... It's actually a whole range of actions that are currently no-op in cycle actions: command ID 2000 through 2023.

@cfillion cfillion self-assigned this Oct 12, 2022
cfillion added a commit to cfillion/sws that referenced this issue Oct 12, 2022
@cfillion
implement "Wait n seconds before next action" actions in Cycle Actions
744bb80 
Fixes reaper-oss#1656
@cfillion cfillion mentioned this issue Oct 12, 2022
Merged
cfillion added a commit to cfillion/sws that referenced this issue Oct 18, 2022
@cfillion
implement "Wait n seconds before next action" actions in Cycle Actions
0061d6d 
Fixes reaper-oss#1656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfillion cfillion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement "Wait n seconds before next action" actions in Cycle Actions cfillion/sws
2 participants
@cfillion @ovnis82