Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE: First line of SWS dump actions list is empty line #1666

Closed
X-Raym opened this issue Jul 22, 2022 · 3 comments · Fixed by #1687
Closed

ISSUE: First line of SWS dump actions list is empty line #1666

X-Raym opened this issue Jul 22, 2022 · 3 comments · Fixed by #1687
Assignees

Comments

@X-Raym
Copy link
Contributor

X-Raym commented Jul 22, 2022

Hi,

All SWS dump action list actions dump a CSV file, but the first line is empty currently (v2.13.1.0), the header is on the second line.

Surely just a break line to remove somewhere :)

Thx !

@nofishonfriday
Copy link
Collaborator

@cfillion

sws/SnM/SnM_Misc.cpp

Lines 458 to 460 in 60104ce

// flush
fputs("\n", f);
fclose(f);

Do we actually need it?

@cfillion
Copy link
Collaborator

cfillion commented Oct 12, 2022

I don't know what purpose that serves. Opening just once write mode and outputting the desired content should be fine...

@X-Raym
Copy link
Contributor Author

X-Raym commented Oct 12, 2022

@cfillion it is called flush.. i guess the idea was to erase content of any existing files ?
anyway, seems completely unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants