Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut/Copy selected tracks sends: Runs if no sends on tracks #1681

Closed
MonkeyBars3k opened this issue Oct 4, 2022 · 7 comments · Fixed by #1690
Closed

Cut/Copy selected tracks sends: Runs if no sends on tracks #1681

MonkeyBars3k opened this issue Oct 4, 2022 · 7 comments · Fixed by #1690
Assignees

Comments

@MonkeyBars3k
Copy link

I consider this a bug.

If there are no sends on a track, then these actions will erase any previously cut/copied sends in the clipboard, effectively "cutting/copying no sends". This is pretty nonstandard behavior – as a user I would expect that the action would do nothing if no sends are found on the tracks.

@cfillion
Copy link
Collaborator

Makes sense for these actions in isolation, however changing the behavior may have undesirable side effects:

  • "SWS/S&M: Copy selected tracks (with routing)" -> Shouldn't this continue to clear the send/receive clipboard if copied tarcks have no sends/receives?
  • "SWS/S&M: Copy selected tracks routings" -> What should happen if there are sends but no receives (or vice versa)? Clear the receive clipboard (current behavior)? Keep previous contents (suggested behavior)?

@MonkeyBars3k
Copy link
Author

This post was specifically about the actions to cut/copy sends specifically.

I don't think the two actions you name ought to be changed...

cfillion added a commit to cfillion/sws that referenced this issue Oct 12, 2022
… copy in "Copy selected tracks {sends,receives}

Closes reaper-oss#1681
cfillion added a commit to cfillion/sws that referenced this issue Oct 12, 2022
… copy in "{Copy,Cut} selected tracks {sends,receives}"

Closes reaper-oss#1681
cfillion added a commit to cfillion/sws that referenced this issue Oct 12, 2022
… copy in "{Copy,Cut} selected tracks {sends,receives,routing}"

Closes reaper-oss#1681
cfillion added a commit to cfillion/sws that referenced this issue Oct 12, 2022
… copy in "{Copy,Cut} selected tracks {sends,receives,routing}"

Closes reaper-oss#1681
@cfillion
Copy link
Collaborator

cfillion commented Oct 13, 2022

👍 I've added special cases to "{Copy,Cut} selected tracks {sends,receives,routings}" for consistency while preserving the existing clipboard-clearing behavior if there's either sends or receives to copy or if it's "Copy selected tracks (with routing)". (All these actions run the same code.)

There are builds here if you'd like to try: #1690 (comment).

cfillion added a commit to cfillion/sws that referenced this issue Oct 13, 2022
… copy in "{Copy,Cut} selected tracks {sends,receives,routing}"

Closes reaper-oss#1681
@cfillion cfillion self-assigned this Oct 13, 2022
@MonkeyBars3k
Copy link
Author

Sounds good!

I just tried out the new beta you linked and while Copy sends does not overwrite sends anymore (thanks!), I noticed that identical sends don't get copied – it only copies one of them. Is that intentional?

cfillion added a commit to cfillion/sws that referenced this issue Oct 13, 2022
… copy in "{Copy,Cut} selected tracks {sends,receives,routing}"

Closes reaper-oss#1681
cfillion added a commit to cfillion/sws that referenced this issue Oct 13, 2022
… copy in "{Copy,Cut} selected tracks {sends,receives,routing}"

Closes reaper-oss#1681
@cfillion
Copy link
Collaborator

I noticed that identical sends don't get copied – it only copies one of them. Is that intentional?

Can't duplicate here (tried creating two identical sends from track 1 to track 2, selected track 1, ran "Copy sends", selected track 3, ran "Paste sends" and it got both). Which steps are you using?

(Updated the build, fixed bugs occurring when not all selected tracks have sends.)

@MonkeyBars3k
Copy link
Author

I noticed that identical sends don't get copied – it only copies one of them. Is that intentional?

Can't duplicate here

I just tried again and realized that it was user error. Apologies for that, works great! ack

@MonkeyBars3k
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants