Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNM_DeleteObject() working? #520

Closed
Jeff0S opened this issue Jul 8, 2014 · 5 comments
Closed

SNM_DeleteObject() working? #520

Jeff0S opened this issue Jul 8, 2014 · 5 comments

Comments

@Jeff0S
Copy link
Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on October 04, 2012 16:49:03

Hey Jeffos and Fingers,
let me first thank you guys for sharing your work with us in the latest beta, i already love the new funcs. My midi-scripts e.g. have been shortened by about 80% and are also running in less than 1 minute, success!! :D

I tested all of the newly added stuff so far but did spot one thing about SNM_DeleteObject() that is yet a bit unclear to me.
If i do this:

for i in range(10000):
fstr=SNM_CreateFastString("sdtgdtgdsfg")
SNM_DeleteObject(fstr)

my mem is constantly increasing by a amount, but in fact independent of the last line.
Not that i'll ever use 10000 instances of fast strings but since i doesnt get a return from the func if the object has been deleted, i thought i let you know.

Using Fingers FNG_FreeMidiTake() after FNG_AllocMidiTake() does make a huge difference btw.
winXP, python 3.2. here

Thanks guys.

PS, it will probably be a bit quite on my side over the next 6 months (studies trouble), so sorry already if i cant contribute with much feedback :/

cheers
V

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=520

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From jeffos...@gmail.com on October 04, 2012 12:05:36

DANG! This one stinks. Many thanks for the report Veto!!

Fixed for the next build ( r896 ), SNM_DeleteObject will be replaced with a new func SNM_DeleteFastString

(.. and I hope your "troubles" won't long too much ;-)

Status: Fixed
Owner: jeffos...@gmail.com

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on October 04, 2012 16:02:42

cool! thx Jeffos for already looking into it.

not really "troubles", i like to exaggerate a bit from time to time :)
just the usual madness..

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From fingersmcgarnickle on October 10, 2012 12:33:49

Hey, glad it is of some use. You must run FNG_FreeMidiTake() after FNG_AllocMidiTake as you will leak memory and your changes will not be applied to the midi take. I have some wrapper code around using the midi stuff, to make it more safe, but I need to add a few things and append it to the main python module in the build.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on October 11, 2012 11:03:54

Sorry Fingers, i think i caused some misunderstanding due to my english ""skills"".
By '...does make a huge difference...' i meant that running not FNG_FreeMidiTake() after FNG_FreeMidiTake() does significantly increase mem on the contrary to running it, like expected.
So everything's ok with that :)

sry again for the confusion.

But that beeing done automatically without user-interaction (if i understand you right) would be pretty cool too.
Looking forward to it!
thx
V

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on October 26, 2012 09:48:27

hey Jeffos,
just fyi, SNM_DeleteFastString especially and also the recent added stuff seems to do their jobs fine here after a quick test.
thanks muchly!
V

@Jeff0S Jeff0S closed this as completed Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant