New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrinking Notes Bug #531

Closed
Jeff0S opened this Issue Jul 8, 2014 · 6 comments

Comments

Projects
None yet
1 participant
@Jeff0S
Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on October 27, 2012 18:57:02

Hey Fingers here is that project file and the script.

There are events on CC3.., I tried with a couple other CC's and received the same result. Just run the script and you should notice that some notes shrink to zero length. As I stated in my post at the REAPER forum this only happens when CC events are present.

Thank you,

Anton

Attachment: Shrinking Notes Bug.RPP Select every n'th note.py

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=531

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From pyt...@yahoo.com on October 27, 2012 10:08:59

A little more info;

I noticed that the bug does'nt appear if you run the script on an item with only one row of notes and I think it even ran fine with three rows of notes.., Oh-yea this is running on Windows Vista.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on October 28, 2012 05:00:09

i can fully reproduce that with a brand new midi item and with just
allocating and freeing a midi take.

Some note-on's get shifted towards some note-off's of the same pitch, so they will instantly set off. I attached the relevant part of the chunk of Anton's project item.

some interesting points i found out:

  • it dont need to be note rows to be buggy
  • it only happens after drawing a specific number of adjacent notes and when at least one cc is in it
@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on October 28, 2012 05:09:55

oh boy..
sorry the formatting went wrong.

Attachment: midi chunk.txt

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From fingersmcgarnickle on October 28, 2012 06:27:14

Thanks mths.funk for looking into it. I fixed it in r923 and r924 . I just changed the sorting function to order by note offset, followed by event type with a special case for note ons.

The issue is that the note-off and note-ons for the same pitch and channel were being switched, so the note-off message for the current note was being put after the note-on message.

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From fingersmcgarnickle on October 28, 2012 06:27:35

Fixed

Status: Fixed

@Jeff0S

This comment has been minimized.

Member

Jeff0S commented Jul 8, 2014

From mths.f...@googlemail.com on October 28, 2012 08:53:16

Great! thanks Fingers!
i remember the horror handling all those tiny corner cases with python :)

@Jeff0S Jeff0S closed this Jul 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment