New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation Item is removed after use "sws/wol: set height to max/min" #860

Closed
Bodzijun opened this Issue Apr 7, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@Bodzijun

Bodzijun commented Apr 7, 2017

Automation Item is removed after use "sws/wol: set height to max/min"
(Max OSX, reaper 5.70 pre3, sws 2.9.4)

@swstim

This comment has been minimized.

Show comment
Hide comment
@swstim

swstim Apr 7, 2017

Member

@wolqws Any ideas?

Member

swstim commented Apr 7, 2017

@wolqws Any ideas?

@wolqws

This comment has been minimized.

Show comment
Hide comment
@wolqws

wolqws Apr 7, 2017

Contributor

Known issue since automation items were added. The bug is in BR_Envelope class since it uses chunks (there's no API) for envelope properties. I have already added support for POOLEDENVINST entry and works correctly, but only when AIs are not connected to underlying envelope. When connected there is this bug: https://www.dropbox.com/s/lnpzj4ldjodoabd/ai%20bug.gif?dl=0

Contributor

wolqws commented Apr 7, 2017

Known issue since automation items were added. The bug is in BR_Envelope class since it uses chunks (there's no API) for envelope properties. I have already added support for POOLEDENVINST entry and works correctly, but only when AIs are not connected to underlying envelope. When connected there is this bug: https://www.dropbox.com/s/lnpzj4ldjodoabd/ai%20bug.gif?dl=0

swstim added a commit that referenced this issue Apr 10, 2017

@mkruselj

This comment has been minimized.

Show comment
Hide comment
@mkruselj

mkruselj Jun 19, 2017

AIs are also removed if using this action:

SWS/wol: Adjust envelope or track height under mouse cursor, zoom center to mouse cursor (MIDI CC relative/mousewheel)

I think all actions that use BR_Envelope need a sanity sweep now that automation items are a thing and WILL be coming. Lots of actions broken right now.

AIs are also removed if using this action:

SWS/wol: Adjust envelope or track height under mouse cursor, zoom center to mouse cursor (MIDI CC relative/mousewheel)

I think all actions that use BR_Envelope need a sanity sweep now that automation items are a thing and WILL be coming. Lots of actions broken right now.

@wolqws

This comment has been minimized.

Show comment
Hide comment
@wolqws

wolqws Jun 19, 2017

Contributor

BR_Envelope class was fixed in the commit above, so all actions work. It only needs to be released.

Contributor

wolqws commented Jun 19, 2017

BR_Envelope class was fixed in the commit above, so all actions work. It only needs to be released.

@mkruselj

This comment has been minimized.

Show comment
Hide comment
@mkruselj

mkruselj Jun 20, 2017

Ah! So it's fixed but not released yet. Didn't catch that! Cool :)

Ah! So it's fixed but not released yet. Didn't catch that! Cool :)

@swstim swstim closed this in 72c0bad Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment