Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWS track height actions should obey track height locking #966

Closed
nofishonfriday opened this issue Mar 26, 2018 · 0 comments
Closed

SWS track height actions should obey track height locking #966

nofishonfriday opened this issue Mar 26, 2018 · 0 comments

Comments

@nofishonfriday
Copy link
Collaborator

@nofishonfriday nofishonfriday commented Mar 26, 2018

In R5.78 track height locking was added.
SWS actions manipulating track height should leave tracks with locked height untouched too I think.

So far came up these actions in the pre forum which 'broke' in this regard:

  • Xenakios/SWS: Set selected tracks heights to A/B
  • SWS: Vertical zoom to selected tracks (and the variants of it)

No API currently to Get/Set track height locked state (afaik) but seems it would be possible via chunk parsing at least (In TRACK chunk, (newly introduced ?) 3rd field in the TRACKHEIGHT entry seems to indicate height locked state).

nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Apr 7, 2018
…oss#966

updates _XENAK_TOGGLETRACKHEIAB, _XENAKIOS_STORETRACKHEIGHTS,
_XENAKIOS_SELTRAXHEIGHTA, _XENAKIOS_SELTRAXHEIGHTB
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Apr 7, 2018
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Apr 7, 2018
…oss#966

updates _XENAK_TOGGLETRACKHEIAB, _XENAKIOS_STORETRACKHEIGHTS,
_XENAKIOS_SELTRAXHEIGHTA, _XENAKIOS_SELTRAXHEIGHTB
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Apr 7, 2018
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Apr 13, 2018
@swstim swstim closed this in 495dcb0 Feb 6, 2019
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue May 8, 2020
…#1221), Add action ""SWS/NF: Toggle track height - and vertical zoom actions obey track height lock" (implements reaper-oss#966)

+revert adding actions "Xenakios/SWS/NF: Set selected tracks heights to A/B, respect height locked tracks" (added in v2.12.0pre)
+refactor "Xenakios/SWS: Set selected tracks heights to A/B" (use COMMAND_T::user)
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue May 25, 2020
…#1221), Add action ""SWS/NF: Toggle track height - and vertical zoom actions obey track height lock" (implements reaper-oss#966)

+revert adding actions "Xenakios/SWS/NF: Set selected tracks heights to A/B, respect height locked tracks" (added in v2.12.0pre)
+refactor "Xenakios/SWS: Set selected tracks heights to A/B" (use COMMAND_T::user)
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Oct 8, 2020
…#1221), Add action ""SWS/NF: Toggle track height - and vertical zoom actions obey track height lock" (implements reaper-oss#966), defaults to off to be consistent with previous SWS version

+revert adding actions "Xenakios/SWS/NF: Set selected tracks heights to A/B, respect height locked tracks" (added in v2.12.0pre)
+refactor "Xenakios/SWS: Set selected tracks heights to A/B" (use COMMAND_T::user)
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Oct 8, 2020
…#1221), Add action "SWS/NF: Toggle track height - and vertical zoom actions obey track height lock" (implements reaper-oss#966), defaults to off to be consistent with previous SWS version

+revert adding actions "Xenakios/SWS/NF: Set selected tracks heights to A/B, respect height locked tracks" (added in v2.12.0pre)
+refactor "Xenakios/SWS: Set selected tracks heights to A/B" (use COMMAND_T::user)
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Oct 8, 2020
…#1221), Add action "SWS/NF: Toggle track height - and vertical zoom actions obey track height lock" (implements reaper-oss#966), defaults to off to be consistent with previous SWS versions

+revert adding actions "Xenakios/SWS/NF: Set selected tracks heights to A/B, respect height locked tracks" (added in v2.12.0pre)
+refactor "Xenakios/SWS: Set selected tracks heights to A/B" (use COMMAND_T::user)
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Oct 8, 2020
…#1221), Add action "SWS/NF: Toggle track height - and vertical zoom actions obey track height lock" (implements reaper-oss#966), defaults to off to be consistent with previous SWS versions

+revert adding actions "Xenakios/SWS/NF: Set selected tracks heights to A/B, respect height locked tracks" (added in v2.12.0pre)
+refactor "Xenakios/SWS: Set selected tracks heights to A/B" (use COMMAND_T::user)
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Oct 11, 2020
…#1221), Add action "SWS/NF: Toggle track height - and vertical zoom actions obey track height lock" (implements reaper-oss#966, hidden for cur. pre-release cycle), defaults to off to be consistent with previous SWS versions

+revert adding actions "Xenakios/SWS/NF: Set selected tracks heights to A/B, respect height locked tracks" (added in v2.12.0pre)
+refactor "Xenakios/SWS: Set selected tracks heights to A/B" (use COMMAND_T::user)
nofishonfriday added a commit to nofishonfriday/sws that referenced this issue Oct 11, 2020
…#1221), Add action "SWS/NF: Toggle track height - and vertical zoom actions obey track height lock" (implements reaper-oss#966), defaults to off to be consistent with previous SWS versions

+revert adding actions "Xenakios/SWS/NF: Set selected tracks heights to A/B, respect height locked tracks" (added in v2.12.0pre)
+refactor "Xenakios/SWS: Set selected tracks heights to A/B" (use COMMAND_T::user)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant