Fix high precision mousewheel shortcuts in multiple actions on REAPER v6.76+ #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfillion
force-pushed
the
v6.76-mwheel-actions
branch
from
ea99e1d
to
8872eb6
Compare
… v6.76+
> v6.76 - February 28 2023
> - Mouse: improve precision of mouse gestures and mousewheel when bound to actions
v5.99 & v6.75
mwdown val=63 val2=-1 relmode=2
mwup val=65 val2=-1 relmode=2
v6.76 & v7.11 (typical)
mwdown val=127 val2=-161 relmode=1
mwup val=1 val2=-161 relmode=1
REAPER v6.76+ encodes val2 (valhw in SWS) from `WM_MOUSEWHEEL`'s delta in `wParam` the following way:
int MWDeltaToVal2(double delta)
{
#ifdef __APPLE__
delta /= 16;
#elifdef _WIN32
delta /= 8;
#endif
delta = std::abs(delta);
delta = std::ceil(delta) - delta;
delta = delta * 256 + 0.5;
return -1 - delta;
}
(On Linux, WM_MOUSEWHEEL with delta other than +-120 appear to be ignored.)
It then uses it like this:
double AdjustRelative(const int relmode, int val, const int val2)
{
switch(relmode) {
case 1:
if(val >= 0x40)
val |= ~0x3f;
break;
case 2:
val -= 0x40;
case 3:
if(val & 0x40)
val = -(val & 0x3f);
default:
return val;
}
if(val == 0 || val2 >= -1)
return val;
const double fraction = static_cast<double>(-1 - val2) / 256.0;
return val >= 0 ? val - fraction : val + fraction;
}
The following actions are affected by this commit (although most of them do not officially support the mousewheel):
- SWS/BR: Adjust playrate
- SWS/S&M: Live Config #n - Apply config
- SWS/S&M: Live Config #n - Preload config
- SWS/S&M: Select project
- SWS/S&M: Trigger preset for FX n of selected track
- SWS/S&M: Trigger preset for selected FX of selected track
- SWS/wol: Adjust envelope or track height under mouse cursor
- SWS/wol: Adjust selected envelope height
- SWS/wol: Adjust selected envelope or last touched track height
cfillion
force-pushed
the
v6.76-mwheel-actions
branch
from
8872eb6
to
99ee393
Compare
|
✅ Build sws 1056-master completed (commit e3c7841ba7 by @cfillion) Windows 64-bitWindows 32-bitmacOS x86 64-bitmacOS x86 32-bitmacOS ARM 64-bitLinux x86 64-bitLinux x86 32-bitLinux ARM 64-bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1787 (comment)
The current SDK does not specify negative values other than -1:
REAPER v7.11 computes
val2(valhwin SWS) fromWM_MOUSEWHEEL's delta inwParamthe following way:(On Linux,
WM_MOUSEWHEELwith delta other than +-120 appear to be ignored.)It then uses it like this in actions (validating that this PR is the correct approach for those values):
The following actions are affected by this commit (although most of them do not officially support the mousewheel):