Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: STEP 6 Clean up un-used styles, remove SASS and move styles to component #1178

Closed
duong-se opened this issue May 8, 2020 · 0 comments · Fixed by #2540
Closed

Refactor: STEP 6 Clean up un-used styles, remove SASS and move styles to component #1178

duong-se opened this issue May 8, 2020 · 0 comments · Fixed by #2540
Assignees
@ant066
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
Front end Kanban
Milestone
Marketplace v2.0

Comments

@duong-se
Copy link
Contributor

duong-se commented May 8, 2020 •
edited by willmcvay
Loading

Background context or User story:

  • We're using CSS module for styles of the marketplace and placed the file in this folder as below
    image

Specification or Acceptance Criteria:

  • We'll move SCSS file to the place where it is used, for example, the file as the image below should move to /src/pages/admin-app/__styles__/admin-app.scss and remove un-use styles
    And apply https://linaria.now.sh/ for styles, remove CSS modules
    image

Suggested solution:

  • Move SCSS file to correct place where it is used and apply https://linaria.now.sh/
  • Apply linaria cx case if else in styles
@duong-se duong-se added feature New feature or request front-end Relates to front end issues needs-triage labels May 8, 2020
@duong-se duong-se added this to the Marketplace v2.0 milestone May 8, 2020
@willmcvay willmcvay added marketplace Relates to the Marketplace and removed needs-triage labels May 10, 2020
@willmcvay willmcvay added this to Needs triage in Foundations Feature Triage via automation May 10, 2020
@willmcvay willmcvay moved this from Needs triage to Feature candidate in Foundations Feature Triage May 10, 2020
@willmcvay willmcvay removed this from Feature candidate in Foundations Feature Triage Aug 18, 2020
@willmcvay willmcvay added this to Backlog in Front end Kanban via automation Aug 18, 2020
@willmcvay willmcvay moved this from Backlog to Ready for dev in Front end Kanban Aug 27, 2020
@willmcvay willmcvay changed the title Refactor: STEP 6 Clean up un-use styles and move styles to it's component Refactor: STEP 6 Clean up un-used styles, remove SASS and move styles to component Aug 27, 2020
@ant066 ant066 self-assigned this Aug 31, 2020
@ant066 ant066 moved this from Ready for dev to In progress in Front end Kanban Aug 31, 2020
@ant066 ant066 mentioned this issue Aug 31, 2020
Merged
14 tasks
ant066 pushed a commit that referenced this issue Sep 1, 2020
refactor: #1178 Clean up un-used styles, remove SASS and move styles …
6c52ad4 
…to component (#2540)
@ant066 ant066 moved this from In progress to Verifying on dev in Front end Kanban Sep 1, 2020
@willmcvay willmcvay moved this from Verifying on dev to QA in Front end Kanban Sep 3, 2020
@HollyJoyPhillips HollyJoyPhillips moved this from QA to Done in Front end Kanban Sep 4, 2020
@snyk-bot snyk-bot mentioned this issue Apr 13, 2021
Closed
@snyk-bot snyk-bot mentioned this issue Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ant066 ant066

Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
No open projects
Front end Kanban
  
Done
Milestone
Marketplace v2.0
Development

Successfully merging a pull request may close this issue.

refactor: #1178 Clean up un-used styles, remove SASS and move styles to component reapit/foundations
3 participants
@willmcvay @duong-se @ant066