fix: various app-builder issues #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
joshbalfour
changed the title
willmcvay
requested changes
Sep 20, 2021
| @@ -9,6 +8,7 @@ export const slugToCamel = (str) => | |||
| const capitalize = (s) => s && s[0].toUpperCase() + s.slice(1) | |||
|
|
|||
| export const lint = async (code: string): Promise<string> => { | |||
| const baseEslint = require('@reapit/ts-scripts/src/eslint/base-eslint') // inline import because ts-scripts has dependency issues | |||
There was a problem hiding this comment.
Think this is just because you need to have the eslint executable in scope in your package - can explain in the morning!
| twitter: false, | ||
| yandex: false, | ||
| windows: false, | ||
| const webpackConfigDev = ({ appName }) => { |
There was a problem hiding this comment.
Feels a bit scary because this is used by all the things - bit hard to follow what changed - can you just fill me in in the morning please? Ta!
bashleigh
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Detail as per issue below (required):
fixes: #