Skip to content

Commit

Permalink
Update 550_copy_ldconfig.sh
Browse files Browse the repository at this point in the history
Provide an explanatory comment in 550_copy_ldconfig.sh
what that 'ldconfig.real' thingy is about and
why it is needed (if exists) in the recovery system
so that others understand the reason behind that code
cf. https://github.com/rear/rear/wiki/Coding-Style
  • Loading branch information
jsmeix committed Sep 20, 2017
1 parent bbed83d commit 80aaef4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions usr/share/rear/rescue/GNU/Linux/550_copy_ldconfig.sh
@@ -1,4 +1,7 @@
#
REQUIRED_PROGS=( ${REQUIRED_PROGS[@]} ldconfig )
# On Ubuntu (at least on 16.04) ldconfig is a script that calls ldconfig.real
# so that also ldconfig.real (if exists) is needed in the recovery system
# see https://github.com/rear/rear/issues/1504
PROGS=( "${PROGS[@]}" ldconfig.real )
COPY_AS_IS=( ${COPY_AS_IS[@]} /etc/ld.so.conf /etc/ld.so.conf.d/* )

2 comments on commit 80aaef4

@schlomo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ReaR developers grow to be experts on all Linux distros 😄

@jsmeix
Copy link
Member Author

@jsmeix jsmeix commented on 80aaef4 Sep 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schlomo
you saved my day!
👍

Seriously:
ReaR code is meant that ReaR users can adapt and enhace it
as they need it for their particular use cases so that our code
should be exemplary and easy to understand for every ReaR user.
This way ReaR developers should (hopefully) get contributions
from ReaR users that are correct and easy to understand
so that we could "just merge" such proper contributions.

Please sign in to comment.