Three dangling symlinks in tree

[dagwieers]

The current master branch has 2 dangling symlinks:

[dag@moria rear]$ make validate
find . -name '*.sh' -exec bash -n {} \;
bash: ./usr/share/rear/format/OBDR/default/04_set_NETFS_requirements.sh: No such file or directory
bash: ./usr/share/rear/format/OBDR/default/04_set_tape_device.sh: No such file or directory

These symlinks link towards the prep/OBDR stage where similar files no longer exist:

[dag@moria rear]$ ls -l ./usr/share/rear/format/OBDR/default/04_set_NETFS_requirements.sh ./usr/share/rear/format/OBDR/default/04_set_tape_device.sh
lrwxrwxrwx. 1 dag dag 55 Jun  6 20:13 ./usr/share/rear/format/OBDR/default/04_set_NETFS_requirements.sh -> ../../../prep/OBDR/default/04_set_NETFS_requirements.sh
lrwxrwxrwx. 1 dag dag 48 Jun  6 20:13 ./usr/share/rear/format/OBDR/default/04_set_tape_device.sh -> ../../../prep/OBDR/default/04_set_tape_device.sh

[dagwieers]

I added a validation check for dangling symlinks to the Makefile, which now blocks every usage:

Locating dangling symlinks
find -L . -type l
find: File system loop detected; `./usr/share/rear/skel/default/lib/tls' is part of the same file system loop as `./usr/share/rear/skel/default/lib'.
./usr/share/rear/format/OBDR/default/04_set_NETFS_requirements.sh
./usr/share/rear/format/OBDR/default/04_set_tape_device.sh

So this needs to be fixed ASAP.

[dagwieers]

Can anyone tell me what the /lib/tls/ symlink is for ? It points to itself so I doubt it can work like this.

[dagwieers]

@schlomo @gdha Does any of you remember what the /lib/tls symlink was for ? I'd like to remove it as it does not seem to serve any purpose and blocks both make validate as well as the make dist process.