Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless wrapup/rescue/default/600_add_galaxy_group.sh #1124

Closed
jsmeix opened this issue Dec 14, 2016 · 1 comment
Closed

Useless wrapup/rescue/default/600_add_galaxy_group.sh #1124

jsmeix opened this issue Dec 14, 2016 · 1 comment

Comments

@jsmeix
Copy link
Member

jsmeix commented Dec 14, 2016

As far as I see
wrapup/rescue/default/600_add_galaxy_group.sh
exists but is never called.

Using current GitHub master code:

$ for f in usr/share/rear/lib/*-workflow.sh ; do grep -l wrapup $f ; done
usr/share/rear/lib/finalizeonly-workflow.sh
usr/share/rear/lib/layoutonly-workflow.sh
usr/share/rear/lib/recover-workflow.sh
usr/share/rear/lib/restoreonly-workflow.sh

I.e. only the recover layoutonly restoreonly finalizeonly workflows
call wrapup scripts.

Those are the actually called wrapup scripts:

# for w in recover layoutonly restoreonly finalizeonly ; do echo $w ; usr/sbin/rear -s $w | grep wrapup ; echo ; done
recover
23785: Source wrapup/default/500_post_recovery_script.sh
23785: Source wrapup/default/980_good_bye.sh
23785: Source wrapup/default/990_copy_logfile.sh

layoutonly

restoreonly
24435: Source wrapup/default/500_post_recovery_script.sh
24435: Source wrapup/default/980_good_bye.sh
24435: Source wrapup/default/990_copy_logfile.sh

finalizeonly

In particular no add_galaxy_group script is called directly:

$ find usr/sbin/rear usr/share/rear/* | xargs grep -l 'add_galaxy_group'
[no output]

Searching for the special word 'simpana' in
wrapup/rescue/default/600_add_galaxy_group.sh
finds in particular
rescue/GALAXY10/default/600_add_galaxy_group.sh
which is identical to
wrapup/rescue/default/600_add_galaxy_group.sh

Accordingly I will simply remove
wrapup/rescue/default/600_add_galaxy_group.sh
because it is dead code. As far as I see the right code is
rescue/GALAXY10/default/600_add_galaxy_group.sh

@jsmeix jsmeix added the cleanup label Dec 14, 2016
@jsmeix jsmeix added this to the Rear v2.00 milestone Dec 14, 2016
@jsmeix jsmeix self-assigned this Dec 14, 2016
jsmeix added a commit that referenced this issue Dec 14, 2016
…laxy_group_issue1124

Removed dead wrapup script
wrapup/rescue/default/600_add_galaxy_group.sh
because the identical and right one is
rescue/GALAXY10/default/600_add_galaxy_group.sh
see #1124
@jsmeix
Copy link
Member Author

jsmeix commented Dec 14, 2016

Fixed via
#1125

@jsmeix jsmeix closed this as completed Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant