Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReaR releases should not mention Git in version / Dev builds should mention the Git commit hash #1362

Closed
schlomo opened this issue May 11, 2017 · 4 comments
Closed

ReaR releases should not mention Git in version / Dev builds should mention the Git commit hash #1362

schlomo opened this issue May 11, 2017 · 4 comments
Assignees
@gdha
Labels
enhancement Adaptions and new features fixed / solved / done minor bug An alternative or workaround exists
Milestone
ReaR v2.2

Comments

@schlomo
Copy link
Member

schlomo commented May 11, 2017

ATM the version string of a release (e.g. from EPEL) is Relax-and-Recovery 2.00 / Git which is confusing to customers who think that this is a development build from some git commit and not a real release.

ATM the version string of a dev build contains a date/time string and the date but not the commit hash.

I suggest to improve that so that we are more clear about the release/dev status of a package.
@jsmeix jsmeix added enhancement Adaptions and new features minor bug An alternative or workaround exists labels May 11, 2017
@jsmeix jsmeix added this to the ReaR v2.1 milestone May 11, 2017
@jsmeix
Copy link
Member

jsmeix commented May 11, 2017

I also noitced that but found no time
to investigate what the root cause is.

@gdha gdha self-assigned this May 22, 2017
gdha added a commit that referenced this issue May 22, 2017
@gdha
Adding the release date to the OFFICIAL rear script - issue #1362
403365e
@gdha
Copy link
Member

gdha commented May 22, 2017

@schlomo @jsmeix This will show the effective RELEASE_DATE of an official release date. I suppose this enough for v2.1?

gdha added a commit that referenced this issue May 24, 2017
@gdha
correct some lost lines in the Makefile - issue #1362
5e2957e
gdha added a commit that referenced this issue May 24, 2017
@gdha
moved the endif after the last restore rule in the Makefile - issue #…
36ffd67 
…1362
@gdha gdha modified the milestones: ReaR v2.2, ReaR v2.1 May 29, 2017
@gdha
Copy link
Member

gdha commented May 29, 2017

Moved the milestone to v2.2 - for v2.1 we did what we needed to do and we have no time for further corrections/modifications.

@schlomo schlomo mentioned this issue Jun 22, 2017
Closed
schlomo added a commit that referenced this issue Jun 22, 2017
@schlomo
Refactor Makefile to
98e3385 
* use git infos (rev count, hash, branch) in development version
* put resulting dist files in dist/
* not patch the working copy (removed rewrite/restore)
* use debuild to build debian package

Contributes to #1362

This is work in progress and for sure needs more attention for the OBS parts
schlomo added a commit that referenced this issue Jun 22, 2017
@schlomo
Refactor Makefile to
88b56fc 
* use git infos (rev count, hash, branch) in development version
* put resulting dist files in dist/
* not patch the working copy (removed rewrite/restore)
* use debuild to build debian package

Contributes to #1362

This is work in progress and for sure needs more attention for the OBS parts
@schlomo schlomo mentioned this issue Jun 22, 2017
Merged
schlomo added a commit that referenced this issue Jun 27, 2017
@schlomo
Refactor Makefile to
56959b5 
* use git infos (rev count, hash, branch) in development version
* put resulting dist files in dist/
* not patch the working copy (removed rewrite/restore)
* use debuild to build debian package

Contributes to #1362

This is work in progress and for sure needs more attention for the OBS parts
@gdha
Copy link
Member

gdha commented Jul 11, 2017

I think we can close this issue

@gdha gdha closed this as completed Jul 11, 2017
@gdha gdha mentioned this issue Sep 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdha gdha

Labels
enhancement Adaptions and new features fixed / solved / done minor bug An alternative or workaround exists
Projects
None yet
Milestone
ReaR v2.2
Development

No branches or pull requests
3 participants
@schlomo @gdha @jsmeix