Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use hardcoded /tmp but $TMP_DIR #2460

Closed
jsmeix opened this issue Jul 21, 2020 · 1 comment
Closed

Don't use hardcoded /tmp but $TMP_DIR #2460

jsmeix opened this issue Jul 21, 2020 · 1 comment
Assignees
@jsmeix
Labels
cleanup fixed / solved / done
Milestone
ReaR v2.7

Comments

@jsmeix
Copy link
Member

jsmeix commented Jul 21, 2020 •
edited

Cf. https://github.com/rear/rear/pull/2445/files#r448155637

We have several places in the code where hardcoded /tmp is used.
Normally $TMP_DIR should be used instead.
@jsmeix jsmeix added the cleanup label Jul 21, 2020
@jsmeix jsmeix added this to the ReaR v2.7 milestone Jul 21, 2020
@jsmeix jsmeix self-assigned this Jul 21, 2020
@jsmeix jsmeix mentioned this issue Jul 21, 2020
Merged
@jsmeix jsmeix changed the title Don't use hardcoded /tmp but $TMPDIR Don't use hardcoded /tmp but $TMP_DIR Jul 24, 2020
@jsmeix jsmeix mentioned this issue Jul 24, 2020
Merged
jsmeix added a commit that referenced this issue Jul 29, 2020
@jsmeix
Merge pull request #2462 from rear/use_TMP_DIR_issue_2460
6677acc 
Use ReaR specific TMP_DIR (not TMPDIR or hardcoded /tmp)
plus some general cleanup work as noticed "by the way" in scripts,
see #2460
@jsmeix
Copy link
Member Author

jsmeix commented Jul 29, 2020

With #2462 merged
this issue should be fixed
as far as I found possible places in the code with

# find usr/sbin/rear usr/share/rear/ -type f | xargs grep '/tmp' | grep -v ': *#'

and

# find usr/sbin/rear usr/share/rear/ -type f | xargs grep 'TMPDIR'

@jsmeix jsmeix closed this as completed Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsmeix jsmeix

Labels
cleanup fixed / solved / done
Projects
None yet
Milestone
ReaR v2.7
Development

No branches or pull requests
1 participant
@jsmeix