New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported OUTPUT value like OUTPUT=iso is silently ignored or may error out with misleading error messages. #2501
Comments
Simply put: Currently there is basically no syntax checking in ReaR Currently user experience is not an actual development goal for ReaR. Of course we (i.e. the ReaR upstream developers) do not actively work against our users Cf. the section "RPM packages for disaster recovery" in
Further information: Implementing reasonalby good user experience We at ReaR upstream have many open issues about plain functionality, So in foreseeable future there will be no ReaR upstream development time Of course things change when a user needs something implemented |
I tried |
That makes complete sense, and appreciate the very complete response. It's an imense project, and extremely important one. Keep up the good work and park this issue as you feel appropriate. Cheers - Allan |
Technically it is only a minor bug in ReaR when it misbehaves in case of wrong or invalid user settings Meanwhile (as always sleeping over an issue helps a lot ;-) I remember the exceptional place I will add a matching prep/default/036_valid_output_methods.sh |
New prep/default/036_valid_output_methods.sh that errors out when an OUTPUT method seems to be not supported see #2501
@pick34 |
…t_issue2501 New 036_valid_output_methods.sh to error out for unsupported OUTPUT methods: For "rear mkbackup/mkrescue/mkbackuponly/mkopalpba" (i.e. for all workflows that run the 'prep' stage) check that the OUTPUT method is actually implemented i.e. check that a usr/share/rear/output/$OUTPUT directory exists and error out when an OUTPUT method seems to be not supported to ensure that the user cannot specify a non-working OUTPUT in etc/rear/local.conf (cf. usr/share/rear/prep/default/035_valid_backup_methods.sh) see #2501
With #2503 merged |
@pick34 |
much appreciated. And again - much appreciated. Been meaning to install
ReaR for all our physical iron for some time now. Having problems with a
restore and rpcbin but that's for another bug.
Regards - Allan
…On Mon, 19 Oct 2020 at 16:03, Johannes Meixner ***@***.***> wrote:
Closed #2501 <#2501>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2501 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5RC6BWI3S3H2RBSSBL26TSLRBL7ANCNFSM4SRUPINQ>
.
|
@pick34 ReaR 2.6 is our current ReaR upstream release, cf. You may also have a look at the sections In general we at ReaR upstream support (on a voluntary basis) This does not mean we reject all issues with older ReaR versions Therefore "Testing current ReaR upstream GitHub master code" |
Relax-and-Recover (ReaR) Issue Template
Fill in the following items before submitting a new issue
(quick response is not guaranteed with free support):
ReaR version ("/usr/sbin/rear -V"):
Relax-and-Recover 2.5 / Git
OS version ("cat /etc/os-release" or "lsb_release -a" or "cat /etc/rear/os.conf"):
yes it is my first try :-)
Hardware (PC or PowerNV BareMetal or ARM) or virtual machine (KVM guest or PoverVM LPAR):
ESXi guest
System architecture (x86 compatible or PPC64/PPC64LE or what exact ARM device):
x86_64
Firmware (BIOS or UEFI or Open Firmware) and bootloader (GRUB or ELILO or Petitboot):
Bios
Storage (local disk or SSD) and/or SAN (FC or iSCSI or FCoE) and/or multipath (DM or NVMe):
nfs or local
Storage layout ("lsblk -ipo NAME,KNAME,PKNAME,TRAN,TYPE,FSTYPE,SIZE,MOUNTPOINT" or "lsblk" as makeshift):
Description of the issue (ideally so that others can reproduce it):
a) Typo in config file not reported.
b) Script 900_copy_result_files.sh failed silently not installing a README file which causes a latter script to fail. Should this script handle the error better?
But since Im new to ReaR - I could be wrong on this. But from a newbie experience ended up spending more time chasing up my nfs config, doubting someting there since it was just newly installed nas etc... And then it was just that I had a typo in a config file because I typed it in instead of cut and paste.... Who says laziness doesnt pay.
It's a user experience type of thing, more of an enhancement then any major issue,
E.g. local.conf contained "OUTPUT=iso"
Causes a shell script error with a cp failing copying a README file when running rear
The script which causes the error as it looks like it does not copy the README file to /tmp/rear.6YQKxaBfN7OfgB8/tmp/README
/usr/share/rear/output/RSYNC/default/900_copy_result_files.sh
And on this line could see what was going wrong -
cp $v $(get_template "RESULT_usage_$OUTPUT.txt") "${TMP_DIR}/rsync/${RSYNC_PREFIX}/README" >&2
Looking at the potential files to be copied made me check the config file for OUTPUT and indeeed it should be upper case (as is in the man page etc)
Tells me I had messed up the config file, and OUTPUT was incorrectly to iso.
a)
In local.conf use -
OUTPUT=ISO
b)
Get more sleep :-)
Thanks - been meaning to give ReaR a try every since I heard of it.
I am sure, no doubt, it will save me hours at some point !!!!
The text was updated successfully, but these errors were encountered: