Formatting USB drive for efi is broken

[bearpebble]

Relax-and-Recover (ReaR) Issue Template

• ReaR version ("/usr/sbin/rear -V"):
  Relax-and-Recover 2.6 / Git (7c42e2bd3e600d059f24bd0b46526700c1d8bda0)

• Description of the issue (ideally so that others can reproduce it):
  Using usr/sbin/rear format -v -- --efi /dev/sd... does not create the layout required for EFI.
  
  The switch --efi is simply ignored, as it sets FORMAT_EFI=y, which is never used anywhere else in the code.
  

  rear/usr/share/rear/lib/format-workflow.sh

  Lines 32 to 33 in 7c42e2b

  	(-e|--efi)
  	FORMAT_EFI=y

• Workaround, if any:
  Put the line EFI=$FORMAT_EFI right before the following line, since $EFI is never set anywhere.
  

  rear/usr/share/rear/format/USB/default/300_format_usb_disk.sh

  Lines 59 to 61 in 7c42e2b

  	if is_true "$EFI" ; then
  	LogPrint "The --efi toggle was used with format - making an EFI bootable device $RAW_USB_DEVICE"

[gozora]

Shouldn't it be usr/sbin/rear format -v -- --efi /dev/sd (with two dashes in front of efi) ?

V.

[bearpebble]

@gozora you are right, that was a typo in the issue. Sorry about that.
Unfortunately that is not the problem. I used the correct command and it only worked after I applied the workaround, i.e. edited the code

[jsmeix]

@bearpebble
thank you for your issue report.
It is a bug caused by me from #2660

[jsmeix]

Should now be fixed via
d032145

@bearpebble
please test if our latest GitHub master code that contains
that above commit works for you, cf. the section
"Testing current ReaR upstream GitHub master code" in
https://en.opensuse.org/SDB:Disaster_Recovery

[bearpebble]

The usr/sbin/rear format -v -- --efi /dev/sd... command works as expected using d032145.
Thanks for the quick fix @jsmeix

[jsmeix]

@bearpebble
thank you for your prompt test and feedback!

[jsmeix]

I think less than one hour from initial user bug report
to final user confirmation that the fix actually works
is probably our fastest case that we had here.
So - now it's time for my morning coffee and breakfast...