-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETFS tar backup no btrfs subvolumes by default #2928
Comments
Technically it behaves as btrfs behaves. If we changed that we would make things behave incosistently Making the backup is in general external functionality in ReaR ReaR calls a backup tool but ReaR is not meant to be Perhaps I should explain this in more detail in default.conf |
ISTR @antonvoznia saw a similar issue on Fedora, where the default is now also BTRFS and /home got excluded from backup (because it was a subvolume). |
IMO ReaR should treat subvolumes the same way as it does for separate filesystems: pass their mountpoints to the tar command explicitly. But maybe I misunderstand how it works - I have not yet dug deeper in the internal backup inclusion/exclusion code. |
All correct. My question would be "what does the user expect?" And my answer would be: "By default the backup should cover everything" That is why I would like to suggest that by default ReaR NETFS backup should always perform a "full backup" of the system. |
I would not expect a different behavior if |
So what happens on a not-BTRFS system where different directories like |
I am quite sure it is the former - all disk-based filesystems are added to backup by default. |
Then I'd like to see that behaviour for SUSE as well, regardless of the filesystem used |
Offhandedly I may agree that there should not be a different behavior 'tar' with '--one-file-system' has same behavior But now ReaR should have a differnt behavior How should ReaR behave consistently and trustworthy? When the user knows 'tar' is called with '--one-file-system' FYI: I leave this issue now and let other ReaR maintainers |
FYI I refuse to think about what is commonly It is right to ask for what one himself needs. It is OK to forward truthfully what others asked for It is false to "impersonate" others and speak for them. It works best to only focus on hard (technical) facts |
FYI |
I guess that this is currently by design. I'm fine with leaving this as it is till somebody is willing to sponsor a better BTRFS support in ReaR. |
After sleeping on it for some time now Please be patient - I need to try that out. For me crucial parts are
must not get a changed behaviour because a new automatism |
Hello @jsmeix , |
@jsmeix If you have a proposed fix, I can also test it on Fedora. |
@pcahyna
if this works on Fedora (i.e. with 'MOUNTPOINTS' plural) The current layout/save/GNU/Linux/100_create_layout_file.sh |
Fedora 37: lsblk -ipo NAME,KNAME,TRAN,TYPE,FSTYPE,LABEL,SIZE,MOUNTPOINTS
disklayout.conf:
|
Stale issue message |
Stale issue message |
Stale issue message |
Stale issue message |
Stale issue message |
Automatically include mounted BTRF subvolumes in NETFS backups unless they are explicitly excluded. Resolves: rear#2928
Automatically include mounted btrfs subvolumes in NETFS backups unless they are explicitly excluded. Resolves: rear#2928
... unless they are explicitly excluded. Resolves: rear#2928
Stale issue message |
... unless they are explicitly excluded. Resolves: rear#2928
... unless they are explicitly excluded. Resolves: rear#2928
... unless they are explicitly excluded. Resolves: rear#2928
Stale issue message |
This issue will be fixed by |
ReaR 2.7 on Leap 15.4 x86_64
Config:
Disk layout is typical SUSE default
The problem is that important content from
/var
is missing from the backup archive (checking on the backup server):The root cause for this is that the actual backup tar command looks like this and includes only
/
and not the other BTRFS subvolumes. But it also has the--one-file-system
option set so thattar
won't descend into the subvolumes:And the root cause for that is that the
backup-include.txt
only contains/
It seems like we don't add the subvolumes to the backup automatically on BTRFS?? I'm wondering how many SUSE users stumble over that?
And yes, the SUSE-related example config actually explains the problem and provides the solution (thanks for including that @jsmeix !)
Maybe we should add some logic to automatically set the following in case
BACKUP_PROG_INCLUDE
is not defined:Another question: On other systems not using BTRFS, does ReaR behave the same and include only
/
in the backup or all filesystems? If on non-BTRFS systems we include everything by default unless configured differently then I'd suggest to make ReaR behave the same on BTRFS systems too.The text was updated successfully, but these errors were encountered: