Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rear.spec contains obsolete sles_version #479

Closed
gdha opened this issue Oct 17, 2014 · 1 comment
Closed

rear.spec contains obsolete sles_version #479

gdha opened this issue Oct 17, 2014 · 1 comment
Assignees
@gdha
Labels
cleanup enhancement Adaptions and new features fixed / solved / done
Milestone
Rear v1.17

Comments

@gdha
Copy link
Member

gdha commented Oct 17, 2014 

%if %{!?sles_version:1}0
Requires: lsb
%endif

According https://en.opensuse.org/openSUSE:Build_Service_cross_distribution_howto it is obsolete, we better use suse_version instead.
While we are busy we better fix the OS_VERSION variable for SuSe as well (now it is commented out).
And most likely we can replace lsb by lsb-release?
@gdha gdha added enhancement Adaptions and new features cleanup discuss / RFC labels Oct 17, 2014
@gdha gdha self-assigned this Oct 17, 2014
@gdha gdha added this to the Rear v1.17 milestone Oct 17, 2014
gdha added a commit that referenced this issue Oct 17, 2014
@gdha
link the suse_version to OS_VERSION - issue #479
653615b
gdha added a commit that referenced this issue Oct 17, 2014
@gdha
comment the lsb requirement for suse in general
14b9100 
issue #479
@gdha
Copy link
Member Author

gdha commented Feb 23, 2015

added to the release notes so we can close this issue

@gdha gdha closed this as completed Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdha gdha

Labels
cleanup enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Milestone
Rear v1.17
Development

No branches or pull requests
1 participant
@gdha