-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PXE_TFTP_PATH behavior different in rear-1.17 #570
Comments
@gdha maybe do a 1.17.1 release for this one? If we really broke existing setups I would be happy to fix it ASAP. |
@schlomo Indeed I was just looking at the DRLM documentation
I just wonder what the exact link is between |
I miss having tests for this kind of stuff :-( Unfortunately I cannot read from the code exactly how the result should look. |
Just made an issue brainupdaters/drlm#12 for DRLM support team so they can verify how serious this issue is for them. |
Hello, 81_create_pxelinux_cfg.sh result: kernel /$PXE_KERNEL Updated: brainupdaters/drlm#12 Regards, |
@didacog we need to fix ReaR so that it behaves like before adding the stuff for DRLM. Forcing users to change their configuration is basically not OK, unless we have a very strong and convincing reason for doing that. The reason "nobody verified it before release" is not good enough. Since you also use this code path, could I kindly ask you to look into the question of modifying your patch to keep the old behaviour while enabling your use case? |
@schlomo this behavior is the same since rear 1.16. Is not changed in rear 1.17. In 1.17 we only changed OUTPUT_PREFIX to OUTPUT_PREFIX_PXE in 81_create_pxelinux_cfg.sh. but remain with same behavior since 1.16. By default ReaR creates $OUTPUT_PREFIX directory on remote location and without this prefix on 81_create_pxelinux_cfg.sh never found kernel and initrd. This is true without overwriting PXE_CONFIG_PATH or PXE_TFTP_PATH. We never had the need to overwrite these variables. Regards, |
I see. Maybe nobody really used this stuff since before 1.16, who knows. Next question for me would be then: Which behaviour do we actually want to have? |
setting OUTPUT_PREFIX_PXE="" maintain 1.15 behaviour and works well with the other rear defaults. by default is OUTPUT_PREFIX_PXE=$OUTPUT_PREFIX on default.conf and works well if no overwritting any variables. |
@didacog in pull request d711f87 the following was added to the
If I understand the discussion above well then it is OK for you to make variable |
@gdha we have no need to initialize this variable in "init/default/01_set_drlm_env.sh". If it's defined in default.conf. We can provide a value for it throught the DRLM http config service. But if initialized empty in default.conf, this breaks some ReaR default behaviors fixed in 1.16. On the other hand, there is no problem for DRLM if OUTPUT_PREFIX_PXE="" in default.conf, we can overwrite this on our centralized config files. |
I installed rear 1.17.0 on my SLES 12 VM named vsaps12 and executed
rear mkrescue
.3 lines from my
/etc/rear/site.conf
:The output of
rear dump
includes:So I expect the output in the
$PXE_TFTP_PATH
directory, and there it is.But when I look at
pxelinux.cfg/rear-vsaps12
, I see the linesHm, why that? There is no directory vsaps12/, and the file has been
stored correctly into the sap/ directory. Is this a bug or a feature?
BTW, this is not specific for SLES 12. My SLES 11 SP3 boxes create the$(hostname)/$ (hostname).kernel" ...
same config with "kernel =
I think it was nice if either
a) rear writes down the correct directory name in the config or
b) symlinks the directory where the files are put to the directory that
is written in the pxe config ;)
Regards,
Werner
The text was updated successfully, but these errors were encountered: