You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To avoid regressions I will not change any existing functionality.
I will keep the current 'url_host()' function as is.
But I will add explanatory comments that tell
what current 'url_host()' function actually results.
I will add two new functions 'url_hostname()'
and 'url_username()' that result what their name tells.
Then I can use the new functions 'url_hostname()'
and 'url_username()' to implement #845
Current rear master.
While I am trying to implement #845
I get totally confused by what 'url_host()' means.
The current url_host() function in global-functions.sh
does not result the hostname in an URL but
it results simply the part after the scheme.
E.g. for
url_host() results 'foo@bar' and not only 'foo'
as the name of that function indicates.
I tried to 'fix' that so that the url_host() function
results what its name tells but that lead into mess.
The really bad thing is that some places rely on
this obscure behaviour e.g. in global-functions.sh
because sshfs can be called as
Accordingly as a precondition before implementing #845
I have to first clean up the current 'url_host()' mess.
I think I will do the following to avoid regression:
First I rename the current 'url_host()' function into 'url_user_at_host()'
and replace all calls of that function as needed.
Then I add two new functions 'url_host()' and 'url_user()'
that result what their name tells.
Finally I can use the new functions 'url_host()' and 'url_user()'
to implement #845 (comment) properly.
The text was updated successfully, but these errors were encountered: