New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lvmvol with dashes #88
Comments
Can you provide an example of what was incorrectly translated. I noticed that for example it only replaces one instance, while we probably should replace all instances. So it should become |
I tested with /dev/vg-02/lv-test (/dev/mapper/vg--02-lv--test). The vg part is correctly translated, the lv part not. |
@jhoekx Do you see a cause for this problem ? |
Your commit af92078 fixes it, no? Just never tested with a dash in both vg and lv. |
@wdpoorte Can you confirm that only this fixes it ? I thought the problem was that the LV part was never translated. |
@wdpoorte We assume that this issue is fixed now. If this is not the case, please reopen this issue with more detailed information. |
I cannot reopen (no permissions) and did not test yet (no time), but can already say this will not fix the issue. In case of a volume group name with more that 1 dash, this will correct this. We now have this:
but I think we should have this:
|
Fix problems with LVM double-dashes (fixes rear#88)
If a system has logical volumes with dashes, the translation is not done correctly from the /dev/vg/lv name to the /dev/mapper device name and vice versa. lvmgrps with dashes are working fine.
I think the code need to be adapted on the folowing locations:
The text was updated successfully, but these errors were encountered: