New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No REQUIRED_PROGS in conf/GNU/Linux.conf #892
Comments
There is a predefined REQUIRED_PROGS array |
@jsmeix I don't believe this issue is a show stopper for a new release, right? Perhaps, we better move the milestone? |
This is certainly not a show-stopper for the 1.19 release. |
pushing fwd to 2.5 |
moved PROGS from GNU/Linux.conf to default.conf REQUIRED_PROGS #892
I think with #1961 merged I do not yet close this issue because I like to play around a bit more |
I had the dim feeling from the past that the checks With There are two checks with same code, one in usr/sbin/rear and 1.) 2.) 3.) I will clean up the checks that verify all REQUIRED_PROGS exist... |
#1962 intends to solve the issues in |
…sue_892 Cleanup and enhancement of REQUIRED_PROGS and PROGS checks: Moved prep/default/950_check_missing_programs.sh to init/default/950_check_missing_programs.sh and removed the duplicated code from usr/sbin/rear which is now obsolete because 'init' stage scripts are run in any case. Added build/default/950_check_missing_programs.sh symlink that points to init/default/950_check_missing_programs.sh so that this check is run again during 'build' stage (i.e. after the 'prep' and 'layout/save' and 'rescue' stages where additional required programs are added to REQUIRED_PROGS during "rear mkrescue/mkbackup"). Added a simple verification step to build/default/980_verify_rootfs.sh which checks that each program in REQUIRED_PROGS and PROGS (in case of PROGS provided the program exists on the original system) can be found as an executable command within the recovery system. See #892 (comment) and #1962 (comment)
With #1962 merged In the future we may find out that more programs What we will need to improve is that specific scripts which result For example I have an ext4 root filesystem and did # mv /usr/sbin/mkfs /usr/sbin/mkfs.away # mv /usr/sbin/mkfs.ext4 /usr/sbin/mkfs.ext4.away and "rear -D mkrescue" did not error out (or show any kind of message) # find /tmp/rear.2VRqe2odrvdlsPY/rootfs | grep mkfs /tmp/rear.2VRqe2odrvdlsPY/rootfs/bin/mkfs.ext2 /tmp/rear.2VRqe2odrvdlsPY/rootfs/bin/mkfs.jfs /tmp/rear.2VRqe2odrvdlsPY/rootfs/bin/mkfs.ext3 /tmp/rear.2VRqe2odrvdlsPY/rootfs/bin/mkfs.reiserfs /tmp/rear.2VRqe2odrvdlsPY/rootfs/bin/mkfs.vfat /tmp/rear.2VRqe2odrvdlsPY/rootfs/bin/mkfs.btrfs /tmp/rear.2VRqe2odrvdlsPY/rootfs/bin/mkfs.xfs # grep ext4 /tmp/rear.2VRqe2odrvdlsPY/rootfs/.../var/lib/rear/layout/disklayout.conf # Filesystems (only ext2,ext3,ext4,vfat,xfs,reiserfs,btrfs are supported). fs /dev/sda2 / ext4 uuid=aed8d81b-29bf-405e-9049-29a6c0e702d3 label= ... the ext4 root filesystem cannot be recreated. |
Current rear master.
The PROGS array in usr/share/rear/conf/GNU/Linux.conf
lists so many basic tools (like bash grep cat) but there is no
REQUIRED_PROGS array in usr/share/rear/conf/GNU/Linux.conf
I wonder if it wouldn't be better to have
the basic tools in an REQUIRED_PROGS array?
The text was updated successfully, but these errors were encountered: