Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error message references OUTPUT_URL instead of BACKUP_URL #925

Closed
tcerna opened this issue Jul 18, 2016 · 5 comments
Closed

error message references OUTPUT_URL instead of BACKUP_URL #925

tcerna opened this issue Jul 18, 2016 · 5 comments
Assignees
@jsmeix
Labels
bug The code does not do what it is meant to do cleanup fixed / solved / done waiting for info
Milestone
Rear v1.19

Comments

@tcerna
Copy link

tcerna commented Jul 18, 2016

  • rear version (/usr/sbin/rear -V):
    rear-1.17.2-1.el7.noarch
  • OS version (cat /etc/rear/os.conf or lsb_release -a):
    RedHatEnterpriseServer 7
  • rear configuration files (cat /etc/rear/site.conf or cat /etc/rear/local.conf):
# cat /etc/rear/local.conf
BACKUP_URL=file://tmp/rearbackup/

  • Brief description of the issue

    When running 'rear -v mkbackuponly', it raises this error:

ERROR: OUTPUT_URL requires tripple slash ...
  • Steps to Reproduce:
    1. set BACKUP_URL into /etc/rear/local.conf and set path with only to slashes
    2. run rear -v mkbackuponly
  • Actual results:
    ERROR: OUTPUT_URL requires tripple slash ...
  • Expected results:
    ERROR: BACKUP_URL requires tripple slash ...
@jsmeix jsmeix mentioned this issue Jul 18, 2016
Merged
jsmeix added a commit that referenced this issue Jul 18, 2016
@jsmeix
Merge pull request #927 from jsmeix/use_generic_wording_in_check_back…
b73c4d5 
…up_and_output_url_issue925

Use generic wording in error messages
because prep/default/02_translate_url.sh
may translate a BACKUP_URL into an OUTPUT_URL
so that errors in a BACKUP_URL may appear when
testing the translated/derived OUTPUT_URL
see #925

By the way: First steps to be prepared for 'set -e'
which means replacing COMMAND ; StopIfError ...
with COMMAND || Error ...
@jsmeix jsmeix added bug The code does not do what it is meant to do cleanup fixed / solved / done labels Jul 18, 2016
@jsmeix jsmeix added this to the Rear v1.19 milestone Jul 18, 2016
@jsmeix jsmeix self-assigned this Jul 18, 2016
@jsmeix
Copy link
Member

jsmeix commented Jul 18, 2016

With #927
this issue should be fixed.

FYI:
Initially I thought it is only a typo
but actually it was more complicated
because of prep/default/02_translate_url.sh

@jsmeix jsmeix closed this as completed Jul 18, 2016
@jsmeix
Copy link
Member

jsmeix commented Jul 18, 2016

I would very much appreciate it if I could get feedback
whether or not it now also works for you or
if I may have even introduced new issues.

In general regarding how to test the currently
newest rear GitHub master code:

# git clone https://github.com/rear/rear.git
# cd rear
# vi etc/rear/local.conf
# usr/sbin/rear -d -D mkbackup

@tcerna
Copy link
Author

tcerna commented Jul 18, 2016

@jsmeix In which version of rear it is fixed?

@tcerna
Copy link
Author

tcerna commented Jul 18, 2016

Sorry for spam, I found it in issue 927.
Fixed in Rear v1.19.

@jsmeix
Copy link
Member

jsmeix commented Jul 18, 2016

Strictly speaking "will be fixed in the upcoming version 1.19"
(provided you provide feedback that my #927
also makes it work for you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsmeix jsmeix

Labels
bug The code does not do what it is meant to do cleanup fixed / solved / done waiting for info
Projects
None yet
Milestone
Rear v1.19
Development

No branches or pull requests
2 participants
@jsmeix @tcerna